From: Dmitry Voytik <voytikd@gmail.com>
To: Nicolas Schier <n.schier@fritz.com>,
Nathan Chancellor <nathan@kernel.org>
Cc: Nicolas Schier <nsc@kernel.org>, Rong Zhang <i@rong.moe>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
Dmitry Voytik <voytikd@gmail.com>
Subject: [PATCH v3] scripts/config: honor $KBUILD_OUTPUT by default
Date: Sun, 27 Sep 2026 17:41:01 +0200 [thread overview]
Message-ID: <20260927154101.122633-1-voytikd@gmail.com> (raw)
If $KBUILD_OUTPUT is set, use it by default if --file is not passed.
Fix the issue when the script silently updates a stale .config in
the root directory, while the user expects ${KBUILD_OUTPUT}/.config
to be updated.
The problem can be worked around with --file, but this is easy to miss,
and is inconsistent with how the Makefile and other tools work
(e.g., scripts/diffconfig).
How to reproduce the issue:
rm .config
export KBUILD_OUTPUT=.out
make defconfig
./scripts/config \
-e CONFIG_UBSAN
grep: .config: No such file or directory
Signed-off-by: Dmitry Voytik <voytikd@gmail.com>
---
v3:
- Added an example in the commit message how to reproduce the issue
v2:
- Addressed comments by sashiko:
- https://sashiko.dev/#/patchset/20260920064350.17999-1-voytikd%40gmail.com
- use basename when --refresh is used
- remove echo which can be misleading when --file is passed
v1:
- https://lore.kernel.org/all/20260920064350.17999-1-voytikd@gmail.com/
---
scripts/config | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/scripts/config b/scripts/config
index 32428ea909c2..cdee67157fe1 100755
--- a/scripts/config
+++ b/scripts/config
@@ -130,6 +130,10 @@ on_exit() {
trap on_exit EXIT
FN=.config
+if [ -n "${KBUILD_OUTPUT}" ]; then
+ FN=${KBUILD_OUTPUT}/${FN}
+fi
+
CMDS=()
while [[ $# -gt 0 ]]; do
if [ "$1" = "--file" ]; then
@@ -229,7 +233,7 @@ while [ "$1" != "" ] ; do
;;
--refresh)
- yes "" | make oldconfig KCONFIG_CONFIG=$FN
+ yes "" | make oldconfig KCONFIG_CONFIG=$(basename $FN)
;;
*)
--
2.55.0
next reply other threads:[~2026-09-27 15:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 15:41 Dmitry Voytik [this message]
2026-09-29 8:45 ` [PATCH v3] scripts/config: honor $KBUILD_OUTPUT by default Nicolas Schier
2026-09-29 19:15 ` Dmitry Voytik
2026-10-01 15:06 ` Nicolas Schier
2026-10-01 21:40 ` Dmitry Voytik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260927154101.122633-1-voytikd@gmail.com \
--to=voytikd@gmail.com \
--cc=i@rong.moe \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=n.schier@fritz.com \
--cc=nathan@kernel.org \
--cc=nsc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.