Re: [PATCH v1 1/3] regulator: dt-bindings: maxim,max8907: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: broken schema reference to tegra-regulators-coupling.yaml
--

commit 5ef18cb507e67969206ad4c580a12c88380df6ac
Author: Svyatoslav Ryhel <clamor95@gmail.com>

regulator: dt-bindings: maxim,max8907: Convert to DT schema
    
Convert Maxim MAX8907 regulator binding from text to DT schema. Reference
to nvidia,tegra-regulators-coupling in child regulator nodes.

> diff --git a/Documentation/devicetree/bindings/regulator/maxim,max8907.yaml b/Documentation/devicetree/bindings/regulator/maxim,max8907.yaml
> new file mode 100644
> index 0000000000000..e4e1390a49b9b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/maxim,max8907.yaml
> @@ -0,0 +1,285 @@

[ ... ]

> +  regulators:
> +    type: object
> +    additionalProperties: false
> +
> +    patternProperties:
> +      "^(sd[1-3]|ldo([1-9]|1[0-9]|20)|bbat|mbatt|out(5v|33v)|sdby|vrtc)$":
> +        allOf:
> +          - $ref: /schemas/regulator/regulator.yaml#
> +          - $ref: /schemas/regulator/nvidia,tegra-regulators-coupling.yaml#

[Severity: Medium]
Will this reference break the dt_binding_check build target?

The tegra-regulators-coupling binding has not been converted to YAML yet
(it only exists as nvidia,tegra-regulators-coupling.txt in this tree).
Because of this, the dt-schema tool will throw a RefResolutionError when
it attempts to resolve the missing file, which breaks schema validation
for the bindings subsystem.

> +        unevaluatedProperties: false
> +
> +patternProperties:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260927155745.187758-1-clamor95@gmail.com?part=1