All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Abhin Parekadan Jose" <abhinjoses@gmail.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH RFC v2 5/5] misc: Add edu_srpoc surprise removal POC driver
Date: Sun, 27 Sep 2026 17:00:17 +0000	[thread overview]
Message-ID: <20260927170017.D5A0E1F0089A@smtp.kernel.org> (raw)
In-Reply-To: <20260927165459.829900-6-abhinjoses@gmail.com>

> A test driver for the QEMU edu device that reproduces the surprise
> removal hang described in MST's RFC v5 thread.
> 
> - hacked in a reg to the edu device on qemu to raise a delayed irq
> - This driver writes to that reg in remove and waits for the irq to be
>   handled. This simulates del_gendisk() blocked in
>   blk_mq_freeze_queue_wait()
> 
> remove() blocks until the delayed interrupt arrives, 600 seconds after
> it is requested, or until the device is surprise removed and its
> disconnect work runs.  That is the purpose of the driver, so a normal
> unbind takes 600 seconds, and on a QEMU without the delayed interrupt
> register it never returns.  It is only built with CONFIG_EDU_SRPOC.
> 
> Assisted-by: LLM
> Signed-off-by: Abhin Parekadan Jose <abhinjoses@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260927165459.829900-1-abhinjoses@gmail.com?part=5


      reply	other threads:[~2026-09-27 17:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-27 16:54 [PATCH RFC v2 0/5] PCI: pciehp: Report surprise removal during safe removal Abhin Parekadan Jose
2026-09-27 16:54 ` [PATCH RFC v2 1/5] PCI: Report surprise removal event Abhin Parekadan Jose
2026-09-27 17:07   ` sashiko-bot
2026-09-27 16:54 ` [PATCH RFC v2 2/5] PCI: pciehp: Add pci_hp_wait_link_change() Abhin Parekadan Jose
2026-09-27 17:03   ` sashiko-bot
2026-09-27 16:54 ` [PATCH RFC v2 3/5] PCI/DPC: Add pci_dpc_wait_recovery() Abhin Parekadan Jose
2026-09-27 16:59   ` sashiko-bot
2026-09-27 16:54 ` [PATCH RFC v2 4/5] PCI: pciehp: Report surprise removal from pciehp_isr() Abhin Parekadan Jose
2026-09-27 17:02   ` sashiko-bot
2026-09-27 16:54 ` [PATCH RFC v2 5/5] misc: Add edu_srpoc surprise removal POC driver Abhin Parekadan Jose
2026-09-27 17:00   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260927170017.D5A0E1F0089A@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=abhinjoses@gmail.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.