Re: [PATCH v3] dt-bindings: pinctrl: convert nsp-gpio binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] dt-bindings: pinctrl: brcm,nsp-gpio validation bypass for primitive properties
--

commit a919d3facb51d5d2222a14b7538f8617f24e8169
Author: Rosen Penev <rosenp@gmail.com>

dt-bindings: pinctrl: convert nsp-gpio binding

Convert the brcm,nsp-gpio.txt legacy text binding to a YAML schema.
Keep existing required and optional properties, including generic pinconf
child nodes, and configure node matching.

> diff --git a/Documentation/devicetree/bindings/pinctrl/brcm,nsp-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/brcm,nsp-gpio.yaml
> new file mode 100644
> index 0000000000000..e5144da1bf57e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/brcm,nsp-gpio.yaml
[ ... ]
> +  '-hog(-[0-9]+)?$':
> +    type: object
> +    required:
> +      - gpio-hog
> +
> +additionalProperties:
> +  anyOf:
> +    - $ref: '#/$defs/nsp-gpio-pinconf'
> +    - not:
> +        type: object

[Severity: High]
Does this anyOf block with "not: type: object" inadvertently allow any
misspelled or undocumented primitive property (such as typos like
gpui-controller) to bypass dt-binding validation?

If a device tree introduces an unknown top-level primitive property
(like a boolean, integer, or array), it will fall through to
additionalProperties. Since its value is a primitive rather than an
object, it will successfully match the "not: type: object" condition.

Can we instead enforce additionalProperties: false or
unevaluatedProperties: false at the top level and explicitly match valid
child nodes using patternProperties to prevent validation bypass?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260927212748.123558-1-rosenp@gmail.com?part=1