From: Greg KH <gregkh@linuxfoundation.org>
To: Ashmit Kumar <work.ashmitkumar@gmail.com>
Cc: linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: rtl8723bs: replace custom uint with standard unsigned int
Date: Sun, 27 Sep 2026 18:39:22 +0200 [thread overview]
Message-ID: <2026092747-happy-credibly-5b5e@gregkh> (raw)
In-Reply-To: <20260927111632.50423-1-work.ashmitkumar@gmail.com>
On Sun, Sep 27, 2026 at 11:16:32AM +0000, Ashmit Kumar wrote:
> The TODO file for the rtl8723bs driver specifies converting unusual
> variable types. The driver was extensively using the non-standard
> 'uint' type.
>
> Replace all instances of 'uint' with the kernel standard 'unsigned int'
> across the entire driver. This improves code readability and aligns
> with the Linux kernel coding style guidelines.
That's not a good idea. Do this slowly, and pick real variable types
for this. Don't just do search/replace, otherwise we would have done
that a long time ago.
thanks,
gregk -h
prev parent reply other threads:[~2026-09-27 16:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 11:16 [PATCH] staging: rtl8723bs: replace custom uint with standard unsigned int Ashmit Kumar
2026-09-27 16:39 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026092747-happy-credibly-5b5e@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=work.ashmitkumar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.