Re: [PATCH v4 08/22] rust: add bindings for hash.h

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] rust: linkage failure for hash helpers when CONFIG_CRYPTO=n
- [Low] rust: bindings_helper.h include violates alphabetical sorting
--

commit d3a13bbc1d2175dfb4494c82add6ef5923646f93
Author: Alistair Francis <alistair.francis@wdc.com>

rust: add bindings for hash.h

Make the functions crypto_shash_descsize(), crypto_shash_digestsize()
and crypto_free_shash() available to Rust.

> diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helper.h
> index 4b31aa7f432f5..fd223b6c5aafc 100644
> --- a/rust/bindings/bindings_helper.h
> +++ b/rust/bindings/bindings_helper.h
> @@ -30,6 +30,7 @@
>  
>  #include <linux/acpi.h>
>  #include <linux/gpu_buddy.h>
> +#include <crypto/hash.h>

[Severity: Low]
Is this include placed in the correct alphabetical order? 

This file requires alphabetical sorting, but <crypto/hash.h> was placed 
after <linux/gpu_buddy.h> instead of before the <drm/...> and <linux/...> 
headers.

>  #include <drm/drm_device.h>
>  #include <drm/drm_drv.h>

[ ... ]

> diff --git a/rust/helpers/hash.c b/rust/helpers/hash.c
> new file mode 100644
> index 0000000000000..23a63618a3709
> --- /dev/null
> +++ b/rust/helpers/hash.c
> @@ -0,0 +1,18 @@

[ ... ]

> +__rust_helper void rust_helper_crypto_free_shash(struct crypto_shash *tfm)
> +{
> +	crypto_free_shash(tfm);

[Severity: Low]
Will this cause a linkage failure when CONFIG_CRYPTO is disabled?

This unguarded call to crypto_free_shash() resolves to the external symbol 
crypto_destroy_tfm(), which is not compiled when CONFIG_CRYPTO=n.

> +}
> diff --git a/rust/helpers/helpers.c b/rust/helpers/helpers.c
> index 440fb7638e3cb..09ec69f736b19 100644
> --- a/rust/helpers/helpers.c
> +++ b/rust/helpers/helpers.c
> @@ -66,6 +66,7 @@
>  #include "fs.c"
>  #include "fwctl.c"
>  #include "gpu.c"
> +#include "hash.c"

[Severity: Low]
Does this unconditionally compile the hash helpers into the rust_helpers
object?

Because hash.c is included here without any configuration guards, the 
crypto_free_shash() usage above is compiled even when the crypto subsystem
is disabled, leading to the undefined reference link error.

>  #include "interrupt.c"
>  #include "io.c"
>  #include "irq.c"

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928011123.450800-1-alistair.francis@wdc.com?part=8