Re: [PATCH v6 4/7] thermal/drivers/loongson2: Use bitfields and per-SoC thermal ops

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] thermal: misspelled function name loognson2_thermal_set_trips()
--

commit 50b534520f37f80d31dade061303171856000e41
Author: Binbin Zhou <zhoubinbin@loongson.cn>

thermal/drivers/loongson2: Use bitfields and per-SoC thermal ops

This commit replaces open-coded masks and shifts with GENMASK() and FIELD_*
helpers, and defines named constants for the Loongson-2K2000. It also
splits the temperature read and thermal zone operations into SoC-specific
variants.

> diff --git a/drivers/thermal/loongson2_thermal.c b/drivers/thermal/loongson2_thermal.c
> index 45fe6100134ee..0660a74fd9222 100644
> --- a/drivers/thermal/loongson2_thermal.c
> +++ b/drivers/thermal/loongson2_thermal.c
[ ... ]
> @@ -64,71 +77,101 @@ static void loongson2_thermal_set_trip_temp(struct loongson2_thermal_data *data,
>  	data->chip_data->set_trips_regs(data, high, false, enable);
>  }
>  
> -static int loongson2_thermal_set_trips(struct thermal_zone_device *tz, int low, int high)
> +static int loognson2_thermal_set_trips(struct thermal_zone_device *tz, int low, int high)

[Severity: Low]
This isn't a bug, but is there a typo in this function name? It looks like
"loongson2" was accidentally misspelled as "loognson2" here.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1790561983.git.zhoubinbin@loongson.cn?part=4