From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ian Rogers <irogers@google.com>,
James Clark <james.clark@linaro.org>
Cc: Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org,
Masami Hiramatsu <mhiramat@kernel.org>
Subject: [PATCH v1 7/8] perf tools: Looks symbol file first when check debuginfo
Date: Sun, 27 Sep 2026 22:50:54 -0700 [thread overview]
Message-ID: <20260928055055.95144-8-namhyung@kernel.org> (raw)
In-Reply-To: <20260928055055.95144-1-namhyung@kernel.org>
There's a high chance that the file containing the symbol table also has
debug information. Let's check that first before other locations.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/dso.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c
index c36192e7ea557b47..9c8b963906a7e88c 100644
--- a/tools/perf/util/dso.c
+++ b/tools/perf/util/dso.c
@@ -2133,6 +2133,18 @@ void dso__find_dbginfo_type(struct dso *dso)
return;
dso__set_debuginfo_searched(dso);
+ /* Maybe debug info is in the same file with the symbol table */
+ path = dso__get_filename(dso, "", &decomp, dso__symtab_type(dso));
+ if (path) {
+ found = filename__has_section(path, ".debug_info");
+ dso__put_filename(dso, path, decomp);
+ if (found) {
+ dso__set_dbginfo_type(dso, dso__symtab_type(dso));
+ return;
+ }
+ }
+
+ /* Otherwise check distro debug locations */
for (type = dbginfo_types; *type != DSO_BINARY_TYPE__NOT_FOUND; type++) {
path = dso__get_filename(dso, "", &decomp, *type);
if (path == NULL)
--
2.55.0
next prev parent reply other threads:[~2026-09-28 5:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 5:50 [PATCH v1 0/8] perf tools: Cleanup dso debug info access Namhyung Kim
2026-09-28 5:50 ` [PATCH v1 1/8] perf tools: Add dso->dbginfo_type field Namhyung Kim
2026-09-28 5:57 ` sashiko-bot
2026-09-28 5:50 ` [PATCH v1 2/8] perf tools: Factor out dso__find_dbginfo_type() Namhyung Kim
2026-09-28 5:58 ` sashiko-bot
2026-09-28 5:50 ` [PATCH v1 3/8] perf tools: Check system path when check debuginfo Namhyung Kim
2026-09-28 5:59 ` sashiko-bot
2026-09-29 0:37 ` Namhyung Kim
2026-09-28 5:50 ` [PATCH v1 4/8] perf tools: Export dso__get_filename() with type argument Namhyung Kim
2026-09-28 6:13 ` sashiko-bot
2026-09-28 5:50 ` [PATCH v1 5/8] perf tools: Add dso__put_filename() Namhyung Kim
2026-09-28 5:56 ` sashiko-bot
2026-09-28 5:50 ` [PATCH v1 6/8] perf tools: Avoid repeated failing search for debuginfo Namhyung Kim
2026-09-28 6:08 ` sashiko-bot
2026-09-28 5:50 ` Namhyung Kim [this message]
2026-09-28 6:10 ` [PATCH v1 7/8] perf tools: Looks symbol file first when check debuginfo sashiko-bot
2026-09-28 5:50 ` [PATCH v1 8/8] perf tools: Update debuginfo__new() to take DSO Namhyung Kim
2026-09-28 6:02 ` sashiko-bot
2026-09-28 16:45 ` [PATCH v1 0/8] perf tools: Cleanup dso debug info access Arnaldo Carvalho de Melo
2026-09-29 0:38 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928055055.95144-8-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.