From: sashiko-bot@kernel.org
To: "Wenmeng Liu" <wenmeng.liu@oss.qualcomm.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org,
media-ci@linuxtv.org
Subject: Re: [PATCH v5 1/2] dt-bindings: media: i2c: Add Samsung S5KJN5 image sensor
Date: Mon, 28 Sep 2026 08:03:05 +0000 [thread overview]
Message-ID: <20260928080305.AF4841F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260928-sk5jn5-v5-1-19aa0a0a68eb@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing mandatory power supplies in required list
--
commit 63cf73956886cfb3305c7baa8bae6357815e024b
Author: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
dt-bindings: media: i2c: Add Samsung S5KJN5 image sensor
Add device tree bindings for the Samsung S5KJN5, a 50 MP 10-bit RAW
MIPI CSI-2 image sensor controlled over CCI.
> diff --git a/Documentation/devicetree/bindings/media/i2c/samsung,s5kjn5.yaml b/Documentation/devicetree/bindings/media/i2c/samsung,s5kjn5.yaml
> new file mode 100644
> index 0000000000000..fedb274679cd1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/samsung,s5kjn5.yaml
[ ... ]
> + vddio-supply:
> + description:
> + 1.8 volt I/O voltage supply (VDD18). Required for both 1.8 and 1.2 volt
> + I/O operation.
[ ... ]
> +required:
> + - compatible
> + - reg
> + - clocks
> + - port
[Severity: Low]
Should vddio-supply and the other core power supplies be included in this
required list?
The property definition for vddio-supply explicitly notes that it is required
for I/O operation. Omitting these mandatory hardware supplies from the required
list causes schema validation to be overly permissive.
If a device tree node is written without specifying vddio-supply, vddd-supply,
vddm-supply, or vdda-supply, it will silently pass validation. This can cause
initialization failures at runtime when the driver attempts to request them.
> +
> +unevaluatedProperties: false
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260928-sk5jn5-v5-0-19aa0a0a68eb@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-09-28 8:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 7:55 [PATCH v5 0/2] media: i2c: Add Samsung S5KJN5 image sensor Wenmeng Liu
2026-09-28 7:55 ` [PATCH v5 1/2] dt-bindings: " Wenmeng Liu
2026-09-28 8:03 ` sashiko-bot [this message]
2026-09-28 7:55 ` [PATCH v5 2/2] media: i2c: Add Samsung S5KJN5 image sensor driver Wenmeng Liu
2026-09-28 8:14 ` sashiko-bot
2026-09-28 8:59 ` Sakari Ailus
2026-09-28 9:16 ` Wenmeng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928080305.AF4841F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=media-ci@linuxtv.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wenmeng.liu@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.