Re: [PATCH v1] perf test code-reading: Fix duplicate kernel maps and machine leak

[sashiko-bot@kernel.org]

> In do_test_code_reading(), machine__new_host(&host_env) already calls
> machine__create_kernel_maps(machine). Calling
> machine__create_kernel_maps(machine) a second time immediately
> afterwards duplicates all kernel module maps in machine->kmaps, causing
> dso__load_kcore()'s module validation (do_validate_kcore_modules()) to
> fail and fall back to /proc/kallsyms.
> 
> Furthermore, when try_kcore is true and !have_kcore, returning
> TEST_CODE_READING_NO_KCORE directly bypasses out_err, leaking the entire
> struct machine, its kernel/module maps and DSOs, all kallsyms symbols,
> and host_env.
> 
> Remove the redundant machine__create_kernel_maps() call, check for
> !machine after machine__new_host(), and jump to out_err when returning
> TEST_CODE_READING_NO_KCORE.
> 
> Fixes: 0fd4008ed755 ("perf test: Use machine__new_host in mmap thread code reading test")
> Assisted-by: Antigravity:gemini-3.1-pro
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928075517.3057621-1-irogers@google.com?part=1