From: SJ Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Donggeun Yoo <donggeunyoo.kernel@gmail.com>,
Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <davidgow@davidgow.net>, SJ Park <sj@kernel.org>,
damon@lists.linux.dev, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-mm@kvack.org
Subject: [PATCH v5 2/2] mm/damon/tests/core-kunit: test the temporal tuner's size quota conversion
Date: Mon, 28 Sep 2026 01:48:15 -0700 [thread overview]
Message-ID: <20260928084816.5575-3-sj@kernel.org> (raw)
In-Reply-To: <20260928084816.5575-1-sj@kernel.org>
From: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
damos_goal_tune_esz_bp_temporal() encodes the size quota in basis
points, so the conversion is exact only up to ULONG_MAX / 10000. Pin
the three sizes around that boundary: the largest one that fits, the
first one that does not, and ULONG_MAX.
Signed-off-by: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
Reviewed-by: SJ Park <sj@kernel.org>
Signed-off-by: SJ Park <sj@kernel.org>
---
mm/damon/tests/core-kunit.h | 48 +++++++++++++++++++++++++++++++++++++
1 file changed, 48 insertions(+)
diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
index ef4b8b85d67b..caf582882f5f 100644
--- a/mm/damon/tests/core-kunit.h
+++ b/mm/damon/tests/core-kunit.h
@@ -2284,6 +2284,53 @@ static void damon_test_rand(struct kunit *test)
}
}
+static void damos_test_esz_goal_temporal(struct kunit *test)
+{
+ struct damos_access_pattern pattern = {};
+ struct damos_watermarks wmarks = {};
+ struct damos_quota quota = {
+ .goal_tuner = DAMOS_QUOTA_GOAL_TUNER_TEMPORAL,
+ };
+ struct damos_quota_goal *goal;
+ struct damon_ctx *ctx;
+ struct damos *s;
+
+ ctx = damon_new_ctx();
+ KUNIT_ASSERT_NOT_NULL(test, ctx);
+
+ s = damon_new_scheme(&pattern, DAMOS_STAT, 0, "a, &wmarks,
+ NUMA_NO_NODE);
+ if (!s) {
+ damon_destroy_ctx(ctx);
+ kunit_skip(test, "scheme alloc fail");
+ }
+ damon_add_scheme(ctx, s);
+
+ goal = damos_new_quota_goal(DAMOS_QUOTA_USER_INPUT, 10000);
+ if (!goal) {
+ damon_destroy_ctx(ctx);
+ kunit_skip(test, "quota goal alloc fail");
+ }
+ goal->current_value = 0;
+ damos_add_quota_goal(&s->quota, goal);
+
+ /* The largest size quota the basis-point conversion can hold. */
+ s->quota.sz = ULONG_MAX / 10000;
+ damos_set_effective_quota(ctx, s);
+ KUNIT_EXPECT_EQ(test, s->quota.esz, ULONG_MAX / 10000);
+
+ /* Any larger one saturates instead of wrapping. */
+ s->quota.sz = ULONG_MAX / 10000 + 1;
+ damos_set_effective_quota(ctx, s);
+ KUNIT_EXPECT_EQ(test, s->quota.esz, ULONG_MAX / 10000);
+
+ s->quota.sz = ULONG_MAX;
+ damos_set_effective_quota(ctx, s);
+ KUNIT_EXPECT_EQ(test, s->quota.esz, ULONG_MAX / 10000);
+
+ damon_destroy_ctx(ctx);
+}
+
static struct kunit_case damon_test_cases[] = {
KUNIT_CASE(damon_test_target),
KUNIT_CASE(damon_test_regions),
@@ -2324,6 +2371,7 @@ static struct kunit_case damon_test_cases[] = {
KUNIT_CASE(damon_test_is_last_region),
KUNIT_CASE(damon_test_walk_control_obsolete),
KUNIT_CASE(damon_test_rand),
+ KUNIT_CASE(damos_test_esz_goal_temporal),
{},
};
--
2.47.3
next prev parent reply other threads:[~2026-09-28 8:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 8:48 [PATCH v5 0/2] mm/damon: fix the temporal goal tuner's size quota conversion SJ Park
2026-09-28 8:48 ` [PATCH v5 1/2] mm/damon/core: prevent size quota overflow in the temporal goal tuner SJ Park
2026-09-28 8:56 ` sashiko-bot
2026-09-28 8:48 ` SJ Park [this message]
2026-09-28 8:53 ` [PATCH v5 2/2] mm/damon/tests/core-kunit: test the temporal tuner's size quota conversion sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928084816.5575-3-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=brendan.higgins@linux.dev \
--cc=damon@lists.linux.dev \
--cc=davidgow@davidgow.net \
--cc=donggeunyoo.kernel@gmail.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.