From: sashiko-bot@kernel.org
To: "Rillian Grant" <rillian.grant@gmail.com>
Cc: lee@kernel.org, robh@kernel.org, devicetree@vger.kernel.org,
linux-leds@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 4/4] leds: flash: lm3643: Describe the LED on the Lenovo ThinkPad X9-15 Gen 1
Date: Mon, 28 Sep 2026 09:49:43 +0000 [thread overview]
Message-ID: <20260928094944.126831F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260928094302.86966-5-rillian.grant@gmail.com>
> The ThinkPad X9-15 Gen 1 enumerates the LM3643 through ACPI (HID
> TXNW3643) without a _DSD, like the X1 Carbon Gen 14. It drives the
> Windows Hello IR flood illuminator with both current sources feeding a
> single LED.
>
> The flash limits were obtained from an ETW trace of the SPB class
> extension during a Windows Hello unlock. The Windows driver programs
> 304 mA per current source (code 0x19 with the LED2 override set) and a
> 400 ms flash timeout.
>
> There is no vendor value for the torch limit, so use the same
> conservative limit as the X1 Carbon Gen 14.
>
> Rename the X1 Carbon Gen 14 nodes after the machine now that the table
> has a second entry. Sources and root node remain shared.
>
> Signed-off-by: Rillian Grant <rillian.grant@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260928094302.86966-1-rillian.grant@gmail.com?part=4
next prev parent reply other threads:[~2026-09-28 9:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 9:42 [PATCH v2 0/4] leds: flash: LM3643 dual LED flash driver Rillian Grant
2026-09-28 9:42 ` [PATCH v2 1/4] dt-bindings: leds: Document TI " Rillian Grant
2026-09-28 9:49 ` sashiko-bot
2026-10-01 6:34 ` Krzysztof Kozlowski
2026-09-28 9:42 ` [PATCH v2 2/4] leds: flash: Add support for the " Rillian Grant
2026-09-28 9:54 ` sashiko-bot
2026-09-28 9:42 ` [PATCH v2 3/4] leds: flash: lm3643: Describe the LED of ACPI boards without LED nodes Rillian Grant
2026-09-28 9:50 ` sashiko-bot
2026-09-28 10:08 ` Rillian Grant
2026-09-28 9:42 ` [PATCH v2 4/4] leds: flash: lm3643: Describe the LED on the Lenovo ThinkPad X9-15 Gen 1 Rillian Grant
2026-09-28 9:49 ` sashiko-bot [this message]
2026-09-29 9:29 ` [PATCH v2 0/4] leds: flash: LM3643 dual LED flash driver Ruslan Koreev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928094944.126831F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rillian.grant@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.