From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE6FBC9833F for ; Mon, 28 Sep 2026 11:40:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=biOI2QS+MXU36DfpKU7nvfz0+JI0VUpcZSbq5aFHsDE=; b=mWr5qJ0a1aOvxK ys4vXYbCp7tEnaNdm4CjwKxxZN1ZfOHlXy9M3nfSBMkSAdd8lKCMh2BYboGbmIqxU159EavDv+By5 CxgEOFuGps9t2+LfzDuZ7mRyHEkYELkGrxwKrn4O7Ogekikf5UZDXy1Y82zjWOdUYHcY3FUEJAkON VrjBleWPgtQf6ondcLeBJcoCHSCfYh30jKwhf/vR9Dwode5zsSw99OS57Zdm1Je3n5t5I2pevi2JS JgaBi38GxlXyXB7mJyyd6c2pSRg/fWv2khRph5l59SIDQgds9Z7C8URPMTovyoDXYeRPISiS4T4WQ 29urp8mI7DHAYeOhddSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xB9iT-00000000UKt-0Wfn; Mon, 28 Sep 2026 11:40:17 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xB9iR-00000000UKi-0Vk1 for linux-phy@lists.infradead.org; Mon, 28 Sep 2026 11:40:15 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 4208E4396E; Mon, 28 Sep 2026 11:40:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B44CC1F00899; Mon, 28 Sep 2026 11:40:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790595614; bh=nZkkNLK68DYMqSO/8Ch3GHxTqU/zwPmP4yVGs6kHnSU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=JnUrCEgN7rQe3C4jMquN3oi4Iv4r5yGHUApC0Yho6y7BpknhZ6QB07noRZS3OLRYR BFrIeC/i0VL4G/h5WL1DgvldK9WS8PQ6jlTPrB7TstfXF46xYln1FpXLf8s6X6bZPK QOxALfEvTNTz1bs+PJN1n9/ICDtEm89TM63TQQNp/3o8oCr+23GHGtvWbHbDd+rSga GVGFCp6cIFDTyjVU7YOm/RkV6hNZMRcEQKPhuWUFhZ/oXzmqQjy06ABpxkj1HP+vW6 rhd23d78unT4VMbb9kbj3RSASH7C4uHt1iTHpwITc12InjqotSPZ52vam2iVPM7iXG 5qQH2DWBsOkmQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v6] phy: qualcomm: qmp-combo: Add USB4/TBT3 configuration data for Hamoa To: "Konrad Dybcio" Cc: linux-phy@lists.infradead.org, robh@kernel.org, vkoul@kernel.org, olteanv@gmail.com, neil.armstrong@linaro.org, devicetree@vger.kernel.org, conor+dt@kernel.org In-Reply-To: <20260928-topic-usb4phy-v6-1-815a73b063ef@oss.qualcomm.com> References: <20260928-topic-usb4phy-v6-1-815a73b063ef@oss.qualcomm.com> Date: Mon, 28 Sep 2026 11:40:13 +0000 Message-Id: <20260928114013.B44CC1F00899@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0xvd10gcGh5OiBxdWFsY29tbTog aW5jb3JyZWN0bHkgbmFtZWQgVFggbWFjcm8gZm9yIFJYIFVDRFIgRkFTVExPQ0sgcmVnaXN0ZXJz Ci0gW0xvd10gcGh5OiBxdWFsY29tbTogdHlwbyBMUEZTIGluc3RlYWQgb2YgTEZQUyBpbiBQQ1Mg VVNCNCBtYWNybwotLQoKY29tbWl0IDlmYjhhNjYwMTY3YmViNTcyN2MwZjU1ZWQyY2U5MjU5NTlh NWUyMWMKQXV0aG9yOiBLb25yYWQgRHliY2lvIDxrb25yYWQuZHliY2lvQG9zcy5xdWFsY29tbS5j b20+CgpwaHk6IHF1YWxjb21tOiBxbXAtY29tYm86IEFkZCBVU0I0L1RCVDMgY29uZmlndXJhdGlv biBkYXRhIGZvciBIYW1vYQoKVGhpcyBjb21taXQgYWRkcyBvZmZzZXRzIGFuZCBjb25maWd1cmF0 aW9uIHRhYmxlcyB0byBzdXBwb3J0IFVTQjQgYW5kClRodW5kZXJib2x0IDMgb3BlcmF0aW9uIG9u IFVTQjQtY2FwYWJsZSBQSFlzIGZvciBIYW1vYSBjaGlwcy4gSXQgZXhwb3NlcyBhCnRoaXJkIFBI WSBzdHJ1Y3R1cmUgZm9yIHRoZSBVU0I0IHN1Yi1QSFkgdG8gYmUgdG9nZ2xlZCBieSB0aGUgVVNC NCByb3V0ZXIKZHJpdmVyLgoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9waHkvcXVhbGNvbW0vcGh5 LXFjb20tcW1wLWNvbWJvLmMgYi9kcml2ZXJzL3BoeS9xdWFsY29tbS9waHktcWNvbS1xbXAtY29t Ym8uYwo+IGluZGV4IGE0ZjEzMGZjMzNlMzkuLjI4NGVmYzNmMjNkNDIgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9waHkvcXVhbGNvbW0vcGh5LXFjb20tcW1wLWNvbWJvLmMKPiArKysgYi9kcml2ZXJz L3BoeS9xdWFsY29tbS9waHktcWNvbS1xbXAtY29tYm8uYwpbIC4uLiBdCj4gQEAgLTIwMjgsNiAr MjEwNyw2OCBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHFtcF9waHlfaW5pdF90YmwgeDFlODAxMDBf dXNiNDNkcF90eF90YmxbXSA9IHsKPiAgCVFNUF9QSFlfSU5JVF9DRkcoUVNFUkRFU19WNl9ONF9U WF9SRVNfQ09ERV9MQU5FX09GRlNFVF9SWCwgMHgwYSksCj4gIH07Cj4gIAo+ICtzdGF0aWMgY29u c3Qgc3RydWN0IHFtcF9waHlfaW5pdF90YmwgeDFlODAxMDBfdXNiNF9yeF90YmxbXSA9IHsKWyAu Li4gXQo+ICsJUU1QX1BIWV9JTklUX0NGRyhRU0VSREVTX1Y2X040X1JYX01PREVfUkFURTNfQjYs IDB4ZTMpLAo+ICsJUU1QX1BIWV9JTklUX0NGRyhRU0VSREVTX1Y2X040X1RYX1VDRFJfRkFTVExP Q0tfQ09VTlRFUl9MT1dfUkFURTIsIDB4MzApLAo+ICsJUU1QX1BIWV9JTklUX0NGRyhRU0VSREVT X1Y2X040X1RYX1VDRFJfRkFTVExPQ0tfQ09VTlRFUl9ISUdIX1JBVEUyLCAweDE0KSwKPiArCVFN UF9QSFlfSU5JVF9DRkcoUVNFUkRFU19WNl9ONF9UWF9VQ0RSX0ZBU1RMT0NLX0NPVU5URVJfTE9X X1JBVEUzLCAweGZmKSwKPiArCVFNUF9QSFlfSU5JVF9DRkcoUVNFUkRFU19WNl9ONF9UWF9VQ0RS X0ZBU1RMT0NLX0NPVU5URVJfSElHSF9SQVRFMywgMHgzZiksCgpbU2V2ZXJpdHk6IExvd10KRG8g dGhlc2UgbWFjcm9zIGhhdmUgYW4gaW5jb3JyZWN0IF9UWF8gcHJlZml4IGluc3RlYWQgb2YgX1JY Xz8gVGhleSBhcmUKYmVpbmcgdXNlZCBpbiB0aGUgUlggaW5pdGlhbGl6YXRpb24gdGFibGUgeDFl ODAxMDBfdXNiNF9yeF90YmwgYW5kIGV2YWx1YXRlIHRvCmFuIG9mZnNldCB3aXRoaW4gdGhlIFJY IGJsb2NrIGFkZHJlc3Mgc3BhY2UuCgo+ICsJUU1QX1BIWV9JTklUX0NGRyhRU0VSREVTX1Y2X040 X1JYX1VDRFJfUElfQ1RSTDEsIDB4ZDApLApbIC4uLiBdCj4gQEAgLTIwNjYsNiArMjIwNywyMyBA QCBzdGF0aWMgY29uc3Qgc3RydWN0IHFtcF9waHlfaW5pdF90YmwgeDFlODAxMDBfdXNiNDNkcF9y eF90YmxbXSA9IHsKPiAgCVFNUF9QSFlfSU5JVF9DRkcoUVNFUkRFU19WNl9ONF9SWF9SWF9CS1VQ X0NUUkwxLCAweDE0KSwKPiAgfTsKPiAgCj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgcW1wX3BoeV9p bml0X3RibCB4MWU4MDEwMF91c2I0X3Bjc190YmxbXSA9IHsKPiArCVFNUF9QSFlfSU5JVF9DRkco UVBIWV9WNl9QQ1NfVVNCNF9QT1dFUl9TVEFURV9DT05GSUczLCAweDRmKSwKWyAuLi4gXQo+ICsJ UU1QX1BIWV9JTklUX0NGRyhRUEhZX1Y2X1BDU19VU0I0X0czX0ZPTV9FUV9DT05GSUczLCAweDI1 KSwKPiArCVFNUF9QSFlfSU5JVF9DRkcoUVBIWV9WNl9QQ1NfVVNCNF9HM19GT01fRVFfQ09ORklH NSwgMHgyMiksCj4gKwlRTVBfUEhZX0lOSVRfQ0ZHKFFQSFlfVjZfUENTX1VTQjRfTFBGU19UWF9F Q1NUQVJULCAweDBmKSwKCltTZXZlcml0eTogTG93XQpUaGlzIGlzIGEgbWlub3IgdHlwbywgYnV0 IHNob3VsZCBMUEZTIGJlIExGUFMgKExvdyBGcmVxdWVuY3kgUGVyaW9kaWMKU2lnbmFsaW5nKSBp biB0aGlzIG1hY3JvIG5hbWU/Cgo+ICt9OwpbIC4uLiBdCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv cGh5L3F1YWxjb21tL3BoeS1xY29tLXFtcC1wY3MtdXNiLXY2LmggYi9kcml2ZXJzL3BoeS9xdWFs Y29tbS9waHktcWNvbS1xbXAtcGNzLXVzYi12Ni5oCj4gaW5kZXggZGY2NzAxNDNmZWIxZS4uMzBm ZGI0MzcxNDZjNCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3BoeS9xdWFsY29tbS9waHktcWNvbS1x bXAtcGNzLXVzYi12Ni5oCj4gKysrIGIvZHJpdmVycy9waHkvcXVhbGNvbW0vcGh5LXFjb20tcW1w LXBjcy11c2ItdjYuaApbIC4uLiBdCj4gQEAgLTE0LDQgKzE0LDE5IEBACj4gICNkZWZpbmUgUVBI WV9WNl9QQ1NfVVNCM19SQ1ZSX0RUQ1RfRExZX1UzX0wJCTB4NDAKPiAgI2RlZmluZSBRUEhZX1Y2 X1BDU19VU0IzX1JDVlJfRFRDVF9ETFlfVTNfSAkJMHg0NAo+ICAKPiArI2RlZmluZSBRUEhZX1Y2 X1BDU19VU0I0X1BPV0VSX1NUQVRFX0NPTkZJRzMJCTB4OTgKWyAuLi4gXQo+ICsjZGVmaW5lIFFQ SFlfVjZfUENTX1VTQjRfRzNfRk9NX0VRX0NPTkZJRzMJCTB4MjEwCj4gKyNkZWZpbmUgUVBIWV9W Nl9QQ1NfVVNCNF9HM19GT01fRVFfQ09ORklHNQkJMHgyMTgKPiArI2RlZmluZSBRUEhZX1Y2X1BD U19VU0I0X0xQRlNfVFhfRUNTVEFSVAkJMHgyMjAKCltTZXZlcml0eTogTG93XQpJcyB0aGlzIGFu b3RoZXIgaW5zdGFuY2Ugd2hlcmUgTFBGUyBzaG91bGQgYmUgTEZQUz8KCj4gKwo+ICAjZW5kaWYK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9waHkvcXVhbGNvbW0vcGh5LXFjb20tcW1wLXFzZXJkZXMt dHhyeC12Nl9uNC5oIGIvZHJpdmVycy9waHkvcXVhbGNvbW0vcGh5LXFjb20tcW1wLXFzZXJkZXMt dHhyeC12Nl9uNC5oCj4gaW5kZXggZDM3Y2MwZDRmZDM2NS4uZTcyYWUyY2I0NjBhYyAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL3BoeS9xdWFsY29tbS9waHktcWNvbS1xbXAtcXNlcmRlcy10eHJ4LXY2 X240LmgKPiArKysgYi9kcml2ZXJzL3BoeS9xdWFsY29tbS9waHktcWNvbS1xbXAtcXNlcmRlcy10 eHJ4LXY2X240LmgKWyAuLi4gXQo+IEBAIC0yMywyNyArMjMsNjMgQEAKPiAgI2RlZmluZSBRU0VS REVTX1Y2X040X1RYX1RSQU5fRFJWUl9FTVBfRU4JCTB4YWMKPiAgI2RlZmluZSBRU0VSREVTX1Y2 X040X1RYX1RYX0JBTkQJCQkweGQ4Cj4gICNkZWZpbmUgUVNFUkRFU19WNl9ONF9UWF9JTlRFUkZB Q0VfU0VMRUNUCQkweGU0ClsgLi4uIF0KPiArI2RlZmluZSBRU0VSREVTX1Y2X040X1JYX1VDRFJf RkFTVExPQ0tfRk9fR0FJTl9SQVRFMwkweDIwMAo+ICsjZGVmaW5lIFFTRVJERVNfVjZfTjRfUlhf VUNEUl9GQVNUTE9DS19TT19HQUlOX1JBVEUzCTB4MjEwCj4gKyNkZWZpbmUgUVNFUkRFU19WNl9O NF9SWF9VQ0RSX1NPX1NBVFVSQVRJT04JCTB4MjE0Cj4gKyNkZWZpbmUgUVNFUkRFU19WNl9ONF9U WF9VQ0RSX0ZBU1RMT0NLX0NPVU5URVJfTE9XX1JBVEUxCTB4MjI0CgpbU2V2ZXJpdHk6IExvd10K RG9lcyB0aGlzIGRlZmluZSBpbmNvcnJlY3RseSB1c2UgdGhlIF9UWF8gcHJlZml4IGluc3RlYWQg b2YgX1JYXz8gVGhpcwpibG9jayBvZiBtYWNyb3MgYXBwZWFycyB0byBmYWxsIHdpdGhpbiB0aGUg UlggYWRkcmVzcyBzcGFjZSBiYXNlZCBvbiB0aGUKc3Vycm91bmRpbmcgb2Zmc2V0cy4KCj4gKyNk ZWZpbmUgUVNFUkRFU19WNl9ONF9UWF9VQ0RSX0ZBU1RMT0NLX0NPVU5URVJfSElHSF9SQVRFMQkw eDIyOAo+ICsjZGVmaW5lIFFTRVJERVNfVjZfTjRfVFhfVUNEUl9GQVNUTE9DS19DT1VOVEVSX0xP V19SQVRFMgkweDIyYwo+ICsjZGVmaW5lIFFTRVJERVNfVjZfTjRfVFhfVUNEUl9GQVNUTE9DS19D T1VOVEVSX0hJR0hfUkFURTIJMHgyMzAKPiArI2RlZmluZSBRU0VSREVTX1Y2X040X1RYX1VDRFJf RkFTVExPQ0tfQ09VTlRFUl9MT1dfUkFURTMJMHgyMzQKPiArI2RlZmluZSBRU0VSREVTX1Y2X040 X1RYX1VDRFJfRkFTVExPQ0tfQ09VTlRFUl9ISUdIX1JBVEUzCTB4MjM4Cj4gICNkZWZpbmUgUVNF UkRFU19WNl9ONF9SWF9VQ0RSX1BJX0NUUkwxCQkJMHgyM2MKWyAuLi4gXQoKLS0gClNhc2hpa28g QUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MDkyOC10b3Bp Yy11c2I0cGh5LXY2LTEtODE1YTczYjA2M2VmQG9zcy5xdWFsY29tbS5jb20/cGFydD0xCgotLSAK bGludXgtcGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw czovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4991E4ABBA9 for ; Mon, 28 Sep 2026 11:40:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790595615; cv=none; b=ZVIGrTi5zz+9JlmfALbR1VBR0WZsPcZYfOxb+rqS+/KfWYQdrT3VIOye7v90LtRUGBjYF26vgfhNUkNIZ5sMcAmoOxr/4cjwVy3vZMvhHrMThygs9w9kj5b4vJSDLhsqPDVZUhfmBG1mYKsqp9ZQ+4zVkdf5dYlETdnrDVlvLcg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790595615; c=relaxed/simple; bh=nxEh3kVw11JYEFX33xLmvWFqab91d7O369PccPR7cDQ=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=IXt+yrTb6q482vbT7iDy37UcbbErRPfv0O3GHKlaX5/Zn5A7CHUZP5io7nnqzVqQGarG1Zk5P78l2x7BP5czQxbvRYzkIxoJdwqgTB9/Q1U/GdNAMaEEKwNq19jZhv0/BNw7vbDTYTIH3WaFW+096rNFvn58ONvt6JweF2KBHdM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JnUrCEgN; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JnUrCEgN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B44CC1F00899; Mon, 28 Sep 2026 11:40:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790595614; bh=nZkkNLK68DYMqSO/8Ch3GHxTqU/zwPmP4yVGs6kHnSU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=JnUrCEgN7rQe3C4jMquN3oi4Iv4r5yGHUApC0Yho6y7BpknhZ6QB07noRZS3OLRYR BFrIeC/i0VL4G/h5WL1DgvldK9WS8PQ6jlTPrB7TstfXF46xYln1FpXLf8s6X6bZPK QOxALfEvTNTz1bs+PJN1n9/ICDtEm89TM63TQQNp/3o8oCr+23GHGtvWbHbDd+rSga GVGFCp6cIFDTyjVU7YOm/RkV6hNZMRcEQKPhuWUFhZ/oXzmqQjy06ABpxkj1HP+vW6 rhd23d78unT4VMbb9kbj3RSASH7C4uHt1iTHpwITc12InjqotSPZ52vam2iVPM7iXG 5qQH2DWBsOkmQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v6] phy: qualcomm: qmp-combo: Add USB4/TBT3 configuration data for Hamoa Reply-To: sashiko-reviews@lists.linux.dev To: "Konrad Dybcio" Cc: linux-phy@lists.infradead.org, robh@kernel.org, vkoul@kernel.org, olteanv@gmail.com, neil.armstrong@linaro.org, devicetree@vger.kernel.org, conor+dt@kernel.org In-Reply-To: <20260928-topic-usb4phy-v6-1-815a73b063ef@oss.qualcomm.com> References: <20260928-topic-usb4phy-v6-1-815a73b063ef@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 28 Sep 2026 11:40:13 +0000 Message-Id: <20260928114013.B44CC1F00899@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [Low] phy: qualcomm: incorrectly named TX macro for RX UCDR FASTLOCK regi= sters - [Low] phy: qualcomm: typo LPFS instead of LFPS in PCS USB4 macro -- commit 9fb8a660167beb5727c0f55ed2ce925959a5e21c Author: Konrad Dybcio phy: qualcomm: qmp-combo: Add USB4/TBT3 configuration data for Hamoa This commit adds offsets and configuration tables to support USB4 and Thunderbolt 3 operation on USB4-capable PHYs for Hamoa chips. It exposes a third PHY structure for the USB4 sub-PHY to be toggled by the USB4 router driver. > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qual= comm/phy-qcom-qmp-combo.c > index a4f130fc33e39..284efc3f23d42 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c [ ... ] > @@ -2028,6 +2107,68 @@ static const struct qmp_phy_init_tbl x1e80100_usb4= 3dp_tx_tbl[] =3D { > QMP_PHY_INIT_CFG(QSERDES_V6_N4_TX_RES_CODE_LANE_OFFSET_RX, 0x0a), > }; > =20 > +static const struct qmp_phy_init_tbl x1e80100_usb4_rx_tbl[] =3D { [ ... ] > + QMP_PHY_INIT_CFG(QSERDES_V6_N4_RX_MODE_RATE3_B6, 0xe3), > + QMP_PHY_INIT_CFG(QSERDES_V6_N4_TX_UCDR_FASTLOCK_COUNTER_LOW_RATE2, 0x30= ), > + QMP_PHY_INIT_CFG(QSERDES_V6_N4_TX_UCDR_FASTLOCK_COUNTER_HIGH_RATE2, 0x1= 4), > + QMP_PHY_INIT_CFG(QSERDES_V6_N4_TX_UCDR_FASTLOCK_COUNTER_LOW_RATE3, 0xff= ), > + QMP_PHY_INIT_CFG(QSERDES_V6_N4_TX_UCDR_FASTLOCK_COUNTER_HIGH_RATE3, 0x3= f), [Severity: Low] Do these macros have an incorrect _TX_ prefix instead of _RX_? They are being used in the RX initialization table x1e80100_usb4_rx_tbl and evaluate= to an offset within the RX block address space. > + QMP_PHY_INIT_CFG(QSERDES_V6_N4_RX_UCDR_PI_CTRL1, 0xd0), [ ... ] > @@ -2066,6 +2207,23 @@ static const struct qmp_phy_init_tbl x1e80100_usb4= 3dp_rx_tbl[] =3D { > QMP_PHY_INIT_CFG(QSERDES_V6_N4_RX_RX_BKUP_CTRL1, 0x14), > }; > =20 > +static const struct qmp_phy_init_tbl x1e80100_usb4_pcs_tbl[] =3D { > + QMP_PHY_INIT_CFG(QPHY_V6_PCS_USB4_POWER_STATE_CONFIG3, 0x4f), [ ... ] > + QMP_PHY_INIT_CFG(QPHY_V6_PCS_USB4_G3_FOM_EQ_CONFIG3, 0x25), > + QMP_PHY_INIT_CFG(QPHY_V6_PCS_USB4_G3_FOM_EQ_CONFIG5, 0x22), > + QMP_PHY_INIT_CFG(QPHY_V6_PCS_USB4_LPFS_TX_ECSTART, 0x0f), [Severity: Low] This is a minor typo, but should LPFS be LFPS (Low Frequency Periodic Signaling) in this macro name? > +}; [ ... ] > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcs-usb-v6.h b/drivers/phy= /qualcomm/phy-qcom-qmp-pcs-usb-v6.h > index df670143feb1e..30fdb437146c4 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcs-usb-v6.h > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcs-usb-v6.h [ ... ] > @@ -14,4 +14,19 @@ > #define QPHY_V6_PCS_USB3_RCVR_DTCT_DLY_U3_L 0x40 > #define QPHY_V6_PCS_USB3_RCVR_DTCT_DLY_U3_H 0x44 > =20 > +#define QPHY_V6_PCS_USB4_POWER_STATE_CONFIG3 0x98 [ ... ] > +#define QPHY_V6_PCS_USB4_G3_FOM_EQ_CONFIG3 0x210 > +#define QPHY_V6_PCS_USB4_G3_FOM_EQ_CONFIG5 0x218 > +#define QPHY_V6_PCS_USB4_LPFS_TX_ECSTART 0x220 [Severity: Low] Is this another instance where LPFS should be LFPS? > + > #endif > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-txrx-v6_n4.h b/dri= vers/phy/qualcomm/phy-qcom-qmp-qserdes-txrx-v6_n4.h > index d37cc0d4fd365..e72ae2cb460ac 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-txrx-v6_n4.h > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-txrx-v6_n4.h [ ... ] > @@ -23,27 +23,63 @@ > #define QSERDES_V6_N4_TX_TRAN_DRVR_EMP_EN 0xac > #define QSERDES_V6_N4_TX_TX_BAND 0xd8 > #define QSERDES_V6_N4_TX_INTERFACE_SELECT 0xe4 [ ... ] > +#define QSERDES_V6_N4_RX_UCDR_FASTLOCK_FO_GAIN_RATE3 0x200 > +#define QSERDES_V6_N4_RX_UCDR_FASTLOCK_SO_GAIN_RATE3 0x210 > +#define QSERDES_V6_N4_RX_UCDR_SO_SATURATION 0x214 > +#define QSERDES_V6_N4_TX_UCDR_FASTLOCK_COUNTER_LOW_RATE1 0x224 [Severity: Low] Does this define incorrectly use the _TX_ prefix instead of _RX_? This block of macros appears to fall within the RX address space based on the surrounding offsets. > +#define QSERDES_V6_N4_TX_UCDR_FASTLOCK_COUNTER_HIGH_RATE1 0x228 > +#define QSERDES_V6_N4_TX_UCDR_FASTLOCK_COUNTER_LOW_RATE2 0x22c > +#define QSERDES_V6_N4_TX_UCDR_FASTLOCK_COUNTER_HIGH_RATE2 0x230 > +#define QSERDES_V6_N4_TX_UCDR_FASTLOCK_COUNTER_LOW_RATE3 0x234 > +#define QSERDES_V6_N4_TX_UCDR_FASTLOCK_COUNTER_HIGH_RATE3 0x238 > #define QSERDES_V6_N4_RX_UCDR_PI_CTRL1 0x23c [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260928-topic-usb4= phy-v6-1-815a73b063ef@oss.qualcomm.com?part=3D1