Re: [PATCH 2/2] SoC: dt-bindings: asahi-kasei,ak4619: Add PDN GPIO support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing gpio header for GPIO_ACTIVE_HIGH
--

commit 8c4430d8f688f6a14fffa90ba8e9b1227185a45b
Author: Alexander Koch <mail@alexanderkoch.net>

SoC: dt-bindings: asahi-kasei,ak4619: Add PDN GPIO support

This commit adds documentation for an optional pdn-gpios property that
enables operation of the PDN pin during initialization.

> diff --git a/Documentation/devicetree/bindings/sound/asahi-kasei,ak4619.yaml b/Documentation/devicetree/bindings/sound/asahi-kasei,ak4619.yaml
> index 2e81947bb8dd9..bc173811a8c46 100644
> --- a/Documentation/devicetree/bindings/sound/asahi-kasei,ak4619.yaml
> +++ b/Documentation/devicetree/bindings/sound/asahi-kasei,ak4619.yaml
[ ... ]
> @@ -49,6 +55,8 @@ examples:
>              compatible = "asahi-kasei,ak4619";
>              reg = <0x10>;
>  
> +            pdn-gpios = <&gpio1 0 GPIO_ACTIVE_HIGH>;

[Severity: Low]
Does this example block require a #include <dt-bindings/gpio/gpio.h> directive
before using GPIO_ACTIVE_HIGH? 

Running make dt_binding_check extracts the example into a dts file and passes
it through the C preprocessor and dtc. Without the header, the undefined literal
causes dtc to fail with a syntax error because the GPIO_ACTIVE_HIGH macro
remains unexpanded.

> +
>              clocks = <&rcar_sound>;
>              clock-names = "mclk";

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928114019.1441752-1-mail@alexanderkoch.net?part=2