From: sashiko-bot@kernel.org
To: "Janosch Frank" <frankja@linux.ibm.com>
Cc: "Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
kvm@vger.kernel.org, "Vasily Gorbik" <gor@linux.ibm.com>,
linux-s390@vger.kernel.org,
"Alexander Gordeev" <agordeev@linux.ibm.com>
Subject: Re: [PATCH v5 1/3] KVM: s390: Improve floating IRQ injection behavior
Date: Mon, 28 Sep 2026 12:45:31 +0000 [thread overview]
Message-ID: <20260928124531.78C1F1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260928123639.34226-2-frankja@linux.ibm.com>
> Floating IRQs can be handled by any VCPU that opened its masks. The
> current design does not check if the mask is open when a floating IRQ
> is injected via the FLIC. It will wakeup the last VCPU that went
> sleeping hoping it's the correct one.
>
> Improve this by checking if the VCPU can deliver that partiqular IRQ
> and if not try to find another VCPU which can take the IRQ.
>
> This is not the final fix around this topic but we'll eventually
> inject a pending IRQ. The current code can easily deadlock a VM and
> with this fix we work around that.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260928123639.34226-1-frankja@linux.ibm.com?part=1
next prev parent reply other threads:[~2026-09-28 12:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 12:30 [PATCH v5 0/3] KVM: s390: Improve floating IRQ injection behavior Janosch Frank
2026-09-28 12:30 ` [PATCH v5 1/3] " Janosch Frank
2026-09-28 12:45 ` sashiko-bot [this message]
2026-09-28 12:30 ` [PATCH v5 2/3] KVM: s390: Kick PV cpus at the right time for service irqs Janosch Frank
2026-09-28 12:48 ` sashiko-bot
2026-09-28 12:30 ` [PATCH v5 3/3] KVM: s390: Add opportunistic floating IRQ delivery Janosch Frank
2026-09-28 12:50 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928124531.78C1F1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.