Re: [PATCH v3 11/12] ARM: dts: imx6ulz: Add Variscite i.MX6ULZ board variants

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: combinatorial explosion of static DT permutations
--

commit fe23e5c3bff1e80a38291b82cb1ef5a3d2caeacc
Author: Stefano Radaelli <stefano.r@variscite.com>

ARM: dts: imx6ulz: Add Variscite i.MX6ULZ board variants

This commit adds 30 new static DTS files for various combinations of
carrier, storage, wireless, and audio options on Variscite i.MX6ULZ boards.

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ulz-var-dart-emmc-sd-card-6ulcustomboard.dts b/arch/arm/boot/dts/nxp/imx/imx6ulz-var-dart-emmc-sd-card-6ulcustomboard.dts
> new file mode 100644
> index 0000000000000..612246fe5638e
> --- /dev/null
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ulz-var-dart-emmc-sd-card-6ulcustomboard.dts
> @@ -0,0 +1,21 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2026 Variscite Ltd. - https://www.variscite.com
> + */
> +
> +/dts-v1/;
> +
> +#include "imx6ulz.dtsi"
> +#include "imx6ulz-var-dart.dtsi"
> +#include "imx6ul-imx6ull-var-emmc.dtsi"
> +#include "imx6ul-imx6ull-var-dart-wm8904.dtsi"
> +#include "imx6ulz-var-dart-6ulcustomboard.dtsi"
> +#include "imx6ul-imx6ull-var-dart-6ulcustomboard-sd-card.dtsi"
> +
> +/ {
> +	model = "Variscite DART-6UL with i.MX6ULZ, eMMC, SD card & WM8904 support on VAR-6ULCustomBoard";
> +	compatible = "variscite,dart-6ul-imx6ulz-emmc-sd-card-6ulcustomboard",
> +		     "variscite,dart-6ul-imx6ulz",
> +		     "fsl,imx6ull",
> +		     "fsl,imx6ulz";
> +};

[Severity: Low]
Does this approach create a combinatorial explosion of static device tree
permutations?

Creating a static .dts file for every combination of storage, Wi-Fi, and audio
options adds 30 new files for the i.MX6ULZ variant alone.

Could device tree overlays (.dtbo) be used here instead of generating static
files for each hardware combination?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1790512621.git.stefano.r@variscite.com?part=11