From: "Ed Maste" <emaste@FreeBSD.org>
To: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Mario Limonciello (AMD)" <superm1@kernel.org>
Cc: amd-gfx@lists.freedesktop.org, Ed Maste <emaste@FreeBSD.org>
Subject: [PATCH] drm/amd/amdgpu: Add newlines in drm_dbg format strings
Date: Mon, 28 Sep 2026 13:30:30 +0000 [thread overview]
Message-ID: <20260928133030.69982-1-emaste@FreeBSD.org> (raw)
From: Ed Maste <emaste@FreeBSD.org>
Signed-off-by: Ed Maste <emaste@FreeBSD.org>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +-
drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
index 1e21e3444802..c283087bb560 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
@@ -311,7 +311,7 @@ static int amdgpu_atomfirmware_get_uma_carveout_info_v2_3(struct amdgpu_device *
if (nr_uma_options > MAX_UMA_OPTION_ENTRIES) {
drm_dbg(adev_to_drm(adev),
- "Number of UMA options exceeds max table size. Options will not be parsed");
+ "Number of UMA options exceeds max table size. Options will not be parsed\n");
return -EINVAL;
}
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
index 62f5c5cbd7f9..d23de711d8cf 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
@@ -720,13 +720,13 @@ static int amdgpu_discovery_init(struct amdgpu_device *adev)
/* Read from file if it is the preferred option */
fw_name = amdgpu_discovery_get_fw_name(adev);
if (fw_name != NULL) {
- drm_dbg(&adev->ddev, "use ip discovery information from file");
+ drm_dbg(&adev->ddev, "use ip discovery information from file\n");
r = amdgpu_discovery_read_binary_from_file(adev, discovery_bin,
fw_name);
if (r)
goto out;
} else {
- drm_dbg(&adev->ddev, "use ip discovery information from memory");
+ drm_dbg(&adev->ddev, "use ip discovery information from memory\n");
r = amdgpu_discovery_read_binary_from_mem(adev, discovery_bin,
is_tmr_in_sysmem);
if (r)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
index 59ea338b554c..0a8dd7241750 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
@@ -1428,7 +1428,7 @@ static int amdgpu_display_framebuffer_init(struct drm_device *dev,
ret = convert_tiling_flags_to_modifier_gfx6(rfb);
if (ret) {
- drm_dbg_kms(dev, "Failed to convert tiling flags 0x%llX to a modifier",
+ drm_dbg_kms(dev, "Failed to convert tiling flags 0x%llX to a modifier\n",
rfb->tiling_flags);
return ret;
}
diff --git a/drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c b/drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c
index 485ecdec9618..363266f3e0a3 100644
--- a/drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c
+++ b/drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c
@@ -235,7 +235,7 @@ static int isp_v4_1_1_hw_init(struct amdgpu_isp *isp)
r = amdgpu_acpi_get_isp4_dev(&acpi_dev);
if (r) {
- drm_dbg(&adev->ddev, "Invalid isp platform detected (%d)", r);
+ drm_dbg(&adev->ddev, "Invalid isp platform detected (%d)\n", r);
/* allow GPU init to progress */
return 0;
}
--
2.55.0
next reply other threads:[~2026-09-29 8:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 13:30 Ed Maste [this message]
2026-09-28 16:20 ` [PATCH] drm/amd/amdgpu: Add newlines in drm_dbg format strings Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928133030.69982-1-emaste@FreeBSD.org \
--to=emaste@freebsd.org \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=superm1@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.