From: sashiko-bot@kernel.org
To: "Josua Mayer" <josua@solid-run.com>
Cc: wsa+renesas@sang-engineering.com, robh@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v9 11/11] arm64: dts: renesas: add support for solidrun rzg2ul som on hb-ripple
Date: Mon, 28 Sep 2026 14:51:20 +0000 [thread overview]
Message-ID: <20260928145121.2B1C21F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260928-rzg2-sr-boards-v9-11-5901e0fc9e44@solid-run.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] dts: invalid physical memory addresses in reserved-memory nodes for 512MB RAM variant
--
commit 92cda0c205abe05e3b0184f1c8a5222e1d09b1d4
Author: Josua Mayer <josua@solid-run.com>
arm64: dts: renesas: add support for solidrun rzg2ul som on hb-ripple
This commit adds device tree support for the SolidRun RZ/G2UL SoM on the
HummingBoard Ripple baseboard. It introduces the new board dts, overlay
files for LEDs, and the shared SoM dtsi.
> diff --git a/arch/arm64/boot/dts/renesas/rzg2ul-sr-som.dtsi b/arch/arm64/boot/dts/renesas/rzg2ul-sr-som.dtsi
> new file mode 100644
> index 0000000000000..c629688189270
> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/rzg2ul-sr-som.dtsi
> @@ -0,0 +1,437 @@
[ ... ]
> + memory@48000000 {
> + /*
> + * Physical RAM starts at 0x40000000, but Renesas RZ/G2 BSPs
> + * reserve and hide the first 128MB for TrustZone by default.
> + *
> + * Minimum size for this SoM is 512MB, and the bootloader patches
> + * the dtb according to the actual RAM size and reservations.
> + */
> + reg = <0x0 0x48000000 0x0 0x18000000>;
> + device_type = "memory";
> + };
[ ... ]
> + reserved-memory {
> + ranges;
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + global_cma: linux,cma@58000000 {
> + compatible = "shared-dma-pool";
> + reg = <0x0 0x58000000 0x0 0x10000000>;
> + reusable;
> + linux,cma-default;
> + };
> +
> + mmp_reserved: linux,multimedia@68000000 {
> + compatible = "shared-dma-pool";
> + reg = <0x0 0x68000000 0x0 0x8000000>;
> + reusable;
> + };
> + };
[Severity: High]
Will these reserved-memory regions cause boot failures on the 512MB SoM
variant?
The memory node defined above sets usable physical RAM starting at 0x48000000
with a size of 0x18000000 (384MB), meaning the physical RAM ends at 0x60000000.
However, the global_cma region extends up to 0x68000000 (exceeding RAM by
128MB), and mmp_reserved starts at 0x68000000, placing it entirely outside of
the defined physical memory bounds.
Additionally, the combined size of these regions (256MB + 128MB = 384MB)
would consume 100% of the usable memory on the 512MB variant. Could these
allocations be scaled or dynamically assigned based on the RAM size to avoid
memory initialization errors?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260928-rzg2-sr-boards-v9-0-5901e0fc9e44@solid-run.com?part=11
next prev parent reply other threads:[~2026-09-28 14:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 14:39 [PATCH v9 00/11] arm64: dts: renesas: Add various SolidRun RZ/G2 based boards Josua Mayer
2026-09-28 14:39 ` [PATCH v9 01/11] dt-bindings: soc: " Josua Mayer
2026-09-28 14:39 ` [PATCH v9 02/11] dt-bindings: pinctrl: renesas,rzg2l-pinctrl: Allow input-/output-disable Josua Mayer
2026-09-28 14:39 ` [PATCH v9 03/11] dt-bindings: usb: cypress,hx3: make peer-hub property optional Josua Mayer
2026-09-28 14:39 ` [PATCH v9 04/11] arm64: dts: renesas: add support for solidrun rzg2l som and hb-iiot evb Josua Mayer
2026-09-28 16:14 ` Geert Uytterhoeven
2026-09-28 14:39 ` [PATCH v9 05/11] arm64: dts: renesas: add support for solidrun rzv2l " Josua Mayer
2026-09-28 14:39 ` [PATCH v9 06/11] arm64: dts: renesas: add support for solidrun rzg2lc " Josua Mayer
2026-09-28 14:56 ` sashiko-bot
2026-09-28 16:03 ` Josua Mayer
2026-09-28 14:39 ` [PATCH v9 07/11] arm64: dts: renesas: rzg2l(c)/rzv2l hb-iiot: add dsi panel dt overlay Josua Mayer
2026-09-28 14:49 ` sashiko-bot
2026-09-28 14:39 ` [PATCH v9 08/11] arm64: dts: renesas: add support for solidrun hb-ripple with rzg2l som Josua Mayer
2026-09-28 14:51 ` sashiko-bot
2026-09-28 15:58 ` Josua Mayer
2026-09-28 16:10 ` Geert Uytterhoeven
2026-09-28 16:21 ` Josua Mayer
2026-09-28 17:00 ` Geert Uytterhoeven
2026-09-28 14:39 ` [PATCH v9 09/11] arm64: dts: renesas: add support for solidrun hb-ripple with rzv2l som Josua Mayer
2026-09-28 14:39 ` [PATCH v9 10/11] arm64: dts: renesas: add support for solidrun hb-ripple with rzg2lc som Josua Mayer
2026-09-28 14:39 ` [PATCH v9 11/11] arm64: dts: renesas: add support for solidrun rzg2ul som on hb-ripple Josua Mayer
2026-09-28 14:51 ` sashiko-bot [this message]
2026-09-28 16:32 ` Josua Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928145121.2B1C21F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=josua@solid-run.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.