Re: [PATCH 5.15.y v4 06/11] KVM: X86: Rename gpte_is_8_bytes to has_4_byte_gpte and invert the direction

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] tools/kvm: inverted page role bit breaks plugin_kvm.c parsing
--

commit e1e76187db8d1987f4d32cf661bdfabf00f858af
Author: Lai Jiangshan <laijs@linux.alibaba.com>

KVM: X86: Rename gpte_is_8_bytes to has_4_byte_gpte and invert the direction

The commit renames the gpte_is_8_bytes bit in the MMU page role to
has_4_byte_gpte and inverts its logic. This removes a special case since
guests with paging disabled do not use 4-byte PTEs.

> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index 2c378064a1db9..d31817fb39620 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
[ ... ]
> @@ -316,7 +316,7 @@ union kvm_mmu_page_role {
>  	u32 word;
>  	struct {
>  		unsigned level:4;
> -		unsigned gpte_is_8_bytes:1;
> +		unsigned has_4_byte_gpte:1;

[Severity: Medium]
Does this logic inversion break userspace tracing tools?

Looking at tools/lib/traceevent/plugins/plugin_kvm.c, the in-tree plugin
parses this raw bit from the role word under the assumption it represents PAE
being enabled (when set to 1):

tools/lib/traceevent/plugins/plugin_kvm.c:union kvm_mmu_page_role {
        unsigned word;
        struct {
                unsigned level:4;
                unsigned cr4_pae:1;

It then prints it as inverted if the bit is zero:

tools/lib/traceevent/plugins/plugin_kvm.c:kvm_mmu_print_role() {
        trace_seq_printf(s, "%u q%u%s %s%s %spae %snxe %swp%s%s%s",
                         ...
                         role.cr4_pae ? "" : "!",

Because this patch inverts the logic in the kernel's role bit without
updating the plugin, will tracing tools like trace-cmd and perf now display
an inverted PAE state (printing 'pae' when disabled, and '!pae' when
enabled)?

>  		unsigned quadrant:2;
>  		unsigned direct:1;
>  		unsigned access:3;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928164427.4699-1-k@mgml.me?part=6