Re: [PATCH v2 3/4] RDMA/rxe: Invalidate MWs on QP destroy

[sashiko-bot@kernel.org]

> A type-2 MW holds a reference to the QP that bound it. If the QP is
> destroyed while an MW is still bound, the MW keeps the QP alive and the
> responder can retain a stale QP association.
> 
> Scanning the global MW pool to find these MWs is unsafe: pool entries are
> struct rxe_pool_elem pointers, and concurrent deallocation can invalidate
> the object being visited. It is also unnecessary because only MWs bound to
> the QP being destroyed are relevant.
> 
> Track type-2 MWs on a per-QP list. Clear qp->valid and stop the send task
> before invalidating the list so a late bind cannot attach a new MW after
> invalidation. Yield between MWs to avoid spending a long time in a
> non-preemptible loop when a QP has many bound MWs.
> 
> Fixes: 32a577b4c3a9 ("RDMA/rxe: Add support for bind MW work requests")
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Dongliang Qin <cccccccccccc777777@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928171756.3254016-1-cccccccccccc777777@gmail.com?part=3