All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Rafael J. Wysocki" <rafael@kernel.org>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	"Will Deacon" <will@kernel.org>,
	"Brendan Jackman" <brendan.jackman@linux.dev>,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	"Byungchul Park" <byungchul@sk.com>,
	"Gregory Price" <gourry@gourry.net>,
	"Ryan Roberts" <ryan.roberts@arm.com>,
	"Dave Young" <ruirui.yang@linux.dev>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Lance Yang" <lance.yang@linux.dev>,
	"Mikulas Patocka" <mpatocka@redhat.com>,
	"Zi Yan" <ziy@nvidia.com>, "Mike Rapoport" <rppt@kernel.org>,
	"Baoquan He" <baoquan.he@linux.dev>,
	"David Howells" <dhowells@redhat.com>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	"Baolin Wang" <baolin.wang@linux.alibaba.com>,
	"Alistair Popple" <apopple@nvidia.com>,
	"Pedro Falcato" <pfalcato@suse.de>,
	"Pasha Tatashin" <pasha.tatashin@soleen.com>,
	"Oscar Salvador" <osalvador@suse.de>,
	"Pratyush Yadav" <pratyush@kernel.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Peter Xu" <peterx@redhat.com>,
	"Benjamin Marzinski" <bmarzins@redhat.com>,
	"Nico Pache" <nico.pache@linux.dev>,
	"Kiryl Shutsemau" <kas@kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Saravana Kannan" <saravanak@kernel.org>,
	"Joshua Hahn" <joshua.hahnjy@gmail.com>,
	"Rob Herring" <robh@kernel.org>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Mike Snitzer" <snitzer@kernel.org>,
	"Matthew Brost" <matthew.brost@intel.com>,
	"Rik van Riel" <riel@surriel.com>, "Harry Yoo" <harry@kernel.org>,
	"Barry Song" <baohua@kernel.org>,
	"Mimi Zohar" <zohar@linux.ibm.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Vlastimil Babka" <vbabka@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"Jarkko Sakkinen" <jarkko@kernel.org>,
	"Lorenzo Stoakes" <ljs@kernel.org>,
	"Jann Horn" <jannh@google.com>,
	"Usama Arif" <usama.arif@linux.dev>,
	"James Morris" <jmorris@namei.org>,
	"Jan Sebastian Götte" <linux@jaseg.de>,
	"Suren Baghdasaryan" <surenb@google.com>,
	"Michal Hocko" <mhocko@suse.com>,
	"James Bottomley" <James.Bottomley@HansenPartnership.com>,
	"David Hildenbrand" <david@kernel.org>,
	"Paul Moore" <paul@paul-moore.com>, "Dev Jain" <dev.jain@arm.com>,
	"Ying Huang" <ying.huang@linux.alibaba.com>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Liam R. Howlett" <liam@infradead.org>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Muchun Song" <muchun.song@linux.dev>,
	"Alasdair Kergon" <agk@redhat.com>
Cc: devicetree@vger.kernel.org, linux-arch@vger.kernel.org,
	conor+dt@kernel.org, robh@kernel.org, linux-doc@vger.kernel.org,
	kexec@lists.infradead.org, dm-devel@lists.linux.dev,
	linux-integrity@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, driver-core@lists.linux.dev,
	linux-fsdevel@vger.kernel.org,
	"Eric Biggers" <ebiggers@kernel.org>,
	linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
	linux-crypto@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 06/12] crypto: api - Allocate tfms from the secret pool
Date: Mon, 28 Sep 2026 17:32:49 +0000	[thread overview]
Message-ID: <20260928173250.18AAB1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260928-crash-memaction-upstream-20260921-v3-6-e511e9ee2329@jaseg.de>

> A tfm's context holds the expanded key schedule, which a crash dump
> would capture.
> 
> Allocate tfms from the secret pool, so that their backing pages are
> marked by crash_memaction for the kdump kernel to wipe.
> The context is a flexible array at the end of struct crypto_tfm and the
> frontend's private data sits in front of the struct, so the whole
> allocation moves into the pool.
> 
> Allocation cost increases by a bucket lookup in crash_memaction. Freeing
> is unchanged.
> 
> Signed-off-by: Jan Sebastian Götte <linux@jaseg.de>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928-crash-memaction-upstream-20260921-v3-0-e511e9ee2329@jaseg.de?part=6


  reply	other threads:[~2026-09-28 17:32 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28 17:17 [PATCH v3 00/12] CRASH_MEMACTION: describe pages to a kdump kernel (was: CRASH_WIPE_SECRETS) Jan Sebastian Götte
2026-09-28 17:17 ` [PATCH v3 01/12] kexec: Add a crash memaction registry Jan Sebastian Götte
2026-09-28 17:36   ` sashiko-bot
2026-09-28 17:17 ` [PATCH v3 02/12] lib, kexec: Add a secret pool for key material Jan Sebastian Götte
2026-09-28 17:36   ` sashiko-bot
2026-09-28 17:17 ` [PATCH v3 03/12] mm: Wire up the crash memaction registry Jan Sebastian Götte
2026-09-28 17:38   ` sashiko-bot
2026-09-28 17:17 ` [PATCH v3 04/12] arm64: Enable " Jan Sebastian Götte
2026-09-28 17:35   ` sashiko-bot
2026-09-28 17:17 ` [PATCH v3 05/12] dm crypt: Allocate key material from the secret pool Jan Sebastian Götte
2026-09-28 17:33   ` sashiko-bot
2026-09-28 17:17 ` [PATCH v3 06/12] crypto: api - Allocate tfms " Jan Sebastian Götte
2026-09-28 17:32   ` sashiko-bot [this message]
2026-09-28 17:17 ` [PATCH v3 07/12] security/keys: Allocate key payloads " Jan Sebastian Götte
2026-09-28 17:32   ` sashiko-bot
2026-09-28 17:17 ` [PATCH v3 08/12] mm: Add VM_CRASH_MARK Jan Sebastian Götte
2026-09-28 17:34   ` sashiko-bot
2026-09-28 17:17 ` [PATCH v3 09/12] mm/rmap: Mark folios mapped into crash_memaction-marked VMAs Jan Sebastian Götte
2026-09-28 17:41   ` sashiko-bot
2026-09-28 17:17 ` [PATCH v3 10/12] mm/madvise: Add MADV_CRASH_SECRET, MADV_CRASH_CACHE and MADV_CRASH_RESET Jan Sebastian Götte
2026-09-28 17:35   ` sashiko-bot
2026-09-28 17:17 ` [PATCH v3 11/12] Documentation/mm: Document the crash memaction registry Jan Sebastian Götte
2026-09-28 17:31   ` sashiko-bot
2026-09-28 17:18 ` [PATCH v3 12/12] kexec: Expose the crash memaction bitmap in debugfs Jan Sebastian Götte
2026-09-28 17:38   ` sashiko-bot
2026-09-28 19:19   ` Randy Dunlap
2026-09-28 17:49 ` [PATCH v3 00/12] CRASH_MEMACTION: describe pages to a kdump kernel (was: CRASH_WIPE_SECRETS) Lorenzo Stoakes (ARM)
2026-09-28 18:58   ` David Hildenbrand (Arm)
2026-09-28 19:02 ` David Hildenbrand (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260928173250.18AAB1F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=agk@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=apopple@nvidia.com \
    --cc=arnd@arndb.de \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=baoquan.he@linux.dev \
    --cc=bmarzins@redhat.com \
    --cc=brendan.jackman@linux.dev \
    --cc=byungchul@sk.com \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=dakr@kernel.org \
    --cc=davem@davemloft.net \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dhowells@redhat.com \
    --cc=dm-devel@lists.linux.dev \
    --cc=driver-core@lists.linux.dev \
    --cc=ebiggers@kernel.org \
    --cc=gourry@gourry.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=harry@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=jannh@google.com \
    --cc=jarkko@kernel.org \
    --cc=jmorris@namei.org \
    --cc=joshua.hahnjy@gmail.com \
    --cc=kas@kernel.org \
    --cc=kexec@lists.infradead.org \
    --cc=keyrings@vger.kernel.org \
    --cc=lance.yang@linux.dev \
    --cc=liam@infradead.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=linux@jaseg.de \
    --cc=ljs@kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=matthew.brost@intel.com \
    --cc=mhocko@suse.com \
    --cc=mpatocka@redhat.com \
    --cc=muchun.song@linux.dev \
    --cc=nico.pache@linux.dev \
    --cc=osalvador@suse.de \
    --cc=pasha.tatashin@soleen.com \
    --cc=paul@paul-moore.com \
    --cc=peterx@redhat.com \
    --cc=pfalcato@suse.de \
    --cc=pratyush@kernel.org \
    --cc=rafael@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=riel@surriel.com \
    --cc=robh@kernel.org \
    --cc=rppt@kernel.org \
    --cc=ruirui.yang@linux.dev \
    --cc=ryan.roberts@arm.com \
    --cc=saravanak@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=serge@hallyn.com \
    --cc=skhan@linuxfoundation.org \
    --cc=snitzer@kernel.org \
    --cc=surenb@google.com \
    --cc=usama.arif@linux.dev \
    --cc=vbabka@kernel.org \
    --cc=will@kernel.org \
    --cc=ying.huang@linux.alibaba.com \
    --cc=ziy@nvidia.com \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.