Re: [PATCH v5 05/10] lpfc: Add handling for when PLOGI or PRLI is dropped during link failure

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] lpfc: clear_bit(NLP_PLOGI_SND) is a no-op since flag is never set
--

commit 0b98cf6de331fab63e77fe03e2cd19be5c4624b1
Author: Nigel Kirkland <nkirkland2304@gmail.com>

lpfc: Add handling for when PLOGI or PRLI is dropped during link failure

This commit adds handling for dropped PLOGI or PRLI during link failures by
clearing their respective send flags and decrementing counters in
lpfc_cmpl_els_link_down(). This is intended to prevent logistical mixups and
allow the login session to recover correctly.

> diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
> index 45aad4cd2dc80..cd431c7bd9f08 100644
> --- a/drivers/scsi/lpfc/lpfc_els.c
> +++ b/drivers/scsi/lpfc/lpfc_els.c
[ ... ]
> @@ -1237,17 +1239,40 @@ lpfc_cmpl_els_link_down(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb,
[ ... ]
> +	if (cmd == ELS_CMD_PLOGI) {
> +		/* A PLOGI ELS IO needs to clear the PLOGI_SND flag to
> +		 * acknowledge the ELS completion and allow recovery. Otherwise
> +		 * a subsequent PLOGI gets rejected as a duplicate.
> +		 */
> +		clear_bit(NLP_PLOGI_SND, &ndlp->nlp_flag);

[Severity: Medium]
Is the NLP_PLOGI_SND flag still being actively used by this state machine?

It appears that this flag is never set anywhere in the lpfc driver codebase.
If NLP_PLOGI_SND is never set, this clear_bit() operation is a silent no-op.

Could this mean the intended PLOGI recovery mechanism is non-functional, and
subsequent PLOGIs might still get rejected?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928181757.21959-1-nkirkland2304@gmail.com?part=5