From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, kernel@xen0n.name,
chenhuacai@kernel.org, tsbogend@alpha.franken.de, deller@gmx.de,
razor@blackwall.org, idosch@nvidia.com, aconole@redhat.com,
ardb@kernel.org, tim.bird@sony.com, loongarch@lists.linux.dev,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next 3/3] net: drop unused LLC-related includes
Date: Mon, 28 Sep 2026 12:08:00 -0700 [thread overview]
Message-ID: <20260928190800.2521749-4-kuba@kernel.org> (raw)
In-Reply-To: <20260928190800.2521749-1-kuba@kernel.org>
The bridge and the openvswitch code include <net/llc.h>,
<net/llc_pdu.h> and <linux/llc.h> without using anything out of them.
parse_ethertype() is the one exception: it wants LLC_SAP_SNAP, which
comes from the uAPI header <linux/llc.h> pulls in, so flow.c keeps
that one. The LLC core has leftovers of its own - slab, string,
interrupt and net_namespace - which it has not used in a long time.
None of this is new, the type 2 removal has just shrunk the LLC
headers enough to make it easy to see.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
net/bridge/br.c | 2 --
net/llc/llc_core.c | 3 ---
net/llc/llc_input.c | 2 --
net/openvswitch/flow.c | 1 -
net/openvswitch/flow_netlink.c | 2 --
net/openvswitch/flow_table.c | 2 --
net/openvswitch/vport-netdev.c | 1 -
7 files changed, 13 deletions(-)
diff --git a/net/bridge/br.c b/net/bridge/br.c
index 09a120b3b76c..c602d6305997 100644
--- a/net/bridge/br.c
+++ b/net/bridge/br.c
@@ -12,8 +12,6 @@
#include <linux/netdevice.h>
#include <linux/etherdevice.h>
#include <linux/init.h>
-#include <linux/llc.h>
-#include <net/llc.h>
#include <net/stp.h>
#include <net/switchdev.h>
diff --git a/net/llc/llc_core.c b/net/llc/llc_core.c
index cde6a0b1509e..eafc57ac903d 100644
--- a/net/llc/llc_core.c
+++ b/net/llc/llc_core.c
@@ -7,13 +7,10 @@
*/
#include <linux/module.h>
-#include <linux/interrupt.h>
#include <linux/if_ether.h>
#include <linux/netdevice.h>
#include <linux/slab.h>
-#include <linux/string.h>
#include <linux/init.h>
-#include <net/net_namespace.h>
#include <net/llc.h>
static LIST_HEAD(llc_sap_list);
diff --git a/net/llc/llc_input.c b/net/llc/llc_input.c
index a8730c54b5c2..6bb4275a8518 100644
--- a/net/llc/llc_input.c
+++ b/net/llc/llc_input.c
@@ -6,8 +6,6 @@
* 2001-2003 by Arnaldo Carvalho de Melo <acme@conectiva.com.br>
*/
#include <linux/netdevice.h>
-#include <linux/slab.h>
-#include <net/net_namespace.h>
#include <net/llc.h>
#include <net/llc_pdu.h>
diff --git a/net/openvswitch/flow.c b/net/openvswitch/flow.c
index 868d9fdf3afd..1c4f3a079044 100644
--- a/net/openvswitch/flow.c
+++ b/net/openvswitch/flow.c
@@ -8,7 +8,6 @@
#include <linux/etherdevice.h>
#include <linux/if_ether.h>
#include <linux/if_vlan.h>
-#include <net/llc_pdu.h>
#include <linux/kernel.h>
#include <linux/jhash.h>
#include <linux/jiffies.h>
diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c
index d8079dee700e..de0053f701b3 100644
--- a/net/openvswitch/flow_netlink.c
+++ b/net/openvswitch/flow_netlink.c
@@ -12,11 +12,9 @@
#include <linux/etherdevice.h>
#include <linux/if_ether.h>
#include <linux/if_vlan.h>
-#include <net/llc_pdu.h>
#include <linux/kernel.h>
#include <linux/jhash.h>
#include <linux/jiffies.h>
-#include <linux/llc.h>
#include <linux/module.h>
#include <linux/in.h>
#include <linux/rcupdate.h>
diff --git a/net/openvswitch/flow_table.c b/net/openvswitch/flow_table.c
index 1e0f9d193eb0..93d36f66e2ac 100644
--- a/net/openvswitch/flow_table.c
+++ b/net/openvswitch/flow_table.c
@@ -11,11 +11,9 @@
#include <linux/etherdevice.h>
#include <linux/if_ether.h>
#include <linux/if_vlan.h>
-#include <net/llc_pdu.h>
#include <linux/kernel.h>
#include <linux/jhash.h>
#include <linux/jiffies.h>
-#include <linux/llc.h>
#include <linux/module.h>
#include <linux/in.h>
#include <linux/rcupdate.h>
diff --git a/net/openvswitch/vport-netdev.c b/net/openvswitch/vport-netdev.c
index 44808cd0fcff..7daea2e44dfa 100644
--- a/net/openvswitch/vport-netdev.c
+++ b/net/openvswitch/vport-netdev.c
@@ -9,7 +9,6 @@
#include <linux/if_bridge.h>
#include <linux/if_vlan.h>
#include <linux/kernel.h>
-#include <linux/llc.h>
#include <linux/rtnetlink.h>
#include <linux/skbuff.h>
#include <linux/openvswitch.h>
--
2.55.0
next prev parent reply other threads:[~2026-09-28 19:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 19:07 [PATCH net-next 0/3] net: move the type 2 sockets out of tree Jakub Kicinski
2026-09-28 19:07 ` [PATCH net-next 1/3] llc: " Jakub Kicinski
2026-10-01 22:35 ` David Laight
2026-09-28 19:07 ` [PATCH net-next 2/3] llc: strip the leftovers of the llc2 removal Jakub Kicinski
2026-09-28 19:08 ` Jakub Kicinski [this message]
2026-09-29 14:11 ` [PATCH net-next 3/3] net: drop unused LLC-related includes Aaron Conole
2026-09-30 8:15 ` [PATCH net-next 0/3] net: move the type 2 sockets out of tree Nikolay Aleksandrov
2026-10-01 8:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928190800.2521749-4-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=aconole@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=ardb@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kernel@xen0n.name \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=tim.bird@sony.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.