All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Zhao Liu" <zhao1.liu@intel.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Vladimir Sementsov-Ogievskiy" <vsementsov@yandex-team.ru>,
	"Jason Wang" <jasowangio@gmail.com>,
	"Eric Blake" <eblake@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Hanna Reitz" <hreitz@redhat.com>,
	"Ani Sinha" <anisinha@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Fabiano Rosas" <farosas@suse.de>, "Peter Xu" <peterx@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	qemu-block@nongnu.org, "John Snow" <jsnow@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@mailo.com>
Subject: [PATCH v3 03/10] qapi: convert/split intros for block commands
Date: Mon, 28 Sep 2026 15:25:50 -0400	[thread overview]
Message-ID: <20260928192557.509157-4-jsnow@redhat.com> (raw)
In-Reply-To: <20260928192557.509157-1-jsnow@redhat.com>

Convert, or split off, intro sections for commands defined in
block.json and block-export.json. In general, this does not currently
impact the way these commands are rendered, except:

1. blockdev-open-tray and blockdev-close-tray see their opening
   paragraphs split apart, which is reflected in the rendered output,
   and

2. block_set_io_throttle and nbd-server-add see their argument
   definitions move up to just below the formalized introductory
   section.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 qapi/block-export.json |  3 +--
 qapi/block.json        | 33 ++++++++++++++++-----------------
 2 files changed, 17 insertions(+), 19 deletions(-)

diff --git a/qapi/block-export.json b/qapi/block-export.json
index e9f7e72c8ee..77459f6321b 100644
--- a/qapi/block-export.json
+++ b/qapi/block-export.json
@@ -235,8 +235,7 @@
 
 ##
 # @nbd-server-add:
-#
-# Export a block node to QEMU's embedded NBD server.
+#     Export a block node to QEMU's embedded NBD server.
 #
 # The export name will be used as the id for the resulting block
 # export.
diff --git a/qapi/block.json b/qapi/block.json
index 53f0a623afa..0a88d405a26 100644
--- a/qapi/block.json
+++ b/qapi/block.json
@@ -128,11 +128,12 @@
 
 ##
 # @blockdev-open-tray:
+#     Opens a block device's tray.
 #
-# Opens a block device's tray.  If there is a block driver state tree
-# inserted as a medium, it will become inaccessible to the guest (but
-# it will remain associated to the block device, so closing the tray
-# will make it accessible again).
+# If there is a block driver state tree inserted as a medium, it will
+# become inaccessible to the guest (but it will remain associated to
+# the block device, so closing the tray will make it accessible
+# again).
 #
 # If the tray was already open before, this will be a no-op.
 #
@@ -181,10 +182,11 @@
 
 ##
 # @blockdev-close-tray:
+#     Closes a block device's tray.
 #
-# Closes a block device's tray.  If there is a block driver state tree
-# associated with the block device (which is currently ejected), that
-# tree will be loaded as the medium.
+# If there is a block driver state tree associated with the block
+# device (which is currently ejected), that tree will be loaded as the
+# medium.
 #
 # If the tray was already closed before, this will be a no-op.
 #
@@ -218,13 +220,12 @@
 
 ##
 # @blockdev-remove-medium:
+#     Removes a medium (a block driver state tree) from a block
+#     device.  That block device's tray must currently be open
+#     (unless there is no attached guest device).
 #
-# Removes a medium (a block driver state tree) from a block device.
-# That block device's tray must currently be open (unless there is no
-# attached guest device).
-#
-# If the tray is open and there is no medium inserted, this will be a
-# no-op.
+# If the tray is open and there is no medium inserted, this will
+# be a no-op.
 #
 # @id: The name or QOM path of the guest device
 #
@@ -429,8 +430,7 @@
 
 ##
 # @block_set_io_throttle:
-#
-# Change I/O throttle limits for a block drive.
+#     Change I/O throttle limits for a block drive.
 #
 # Since QEMU 2.4, each device with I/O limits is member of a throttle
 # group.
@@ -504,8 +504,7 @@
 
 ##
 # @block-latency-histogram-set:
-#
-# Manage read, write and flush latency histograms for the device.
+#     Manage read, write and flush latency histograms for the device.
 #
 # If only @id parameter is specified, remove all present latency
 # histograms for the device.  Otherwise, add/reset some of (or all)
-- 
2.55.0



  parent reply	other threads:[~2026-09-28 19:27 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28 19:25 [PATCH v3 00/10] qapi: convert/split remaining QAPI/QMP intro sections John Snow
2026-09-28 19:25 ` [PATCH v3 01/10] qapi: split intro for HV_BALLOON_STATUS_REPORT John Snow
2026-09-28 19:25 ` [PATCH v3 02/10] qapi: convert/split intros for block-core.json commands John Snow
2026-09-29  6:00   ` Markus Armbruster
2026-09-29 14:58     ` John Snow
2026-09-28 19:25 ` John Snow [this message]
2026-09-29  6:17   ` [PATCH v3 03/10] qapi: convert/split intros for block commands Markus Armbruster
2026-09-29 14:59     ` John Snow
2026-09-28 19:25 ` [PATCH v3 04/10] qapi: convert/split intros for job.json commands John Snow
2026-09-28 19:25 ` [PATCH v3 05/10] qapi: convert/split intros for misc-i386.json commands John Snow
2026-09-28 19:25 ` [PATCH v3 06/10] qapi: convert/split intros for commands John Snow
2026-09-29  6:22   ` Markus Armbruster
2026-09-29 15:03     ` John Snow
2026-09-28 19:25 ` [PATCH v3 07/10] qapi: convert/split intros for enums John Snow
2026-09-28 19:25 ` [PATCH v3 08/10] qapi: split intro sections for events John Snow
2026-09-28 19:25 ` [PATCH v3 09/10] qapi: split intro sections for data structs John Snow
2026-09-28 19:25 ` [PATCH v3 10/10] qapi: split intro sections for inlinable structs John Snow
2026-09-29  6:24   ` Markus Armbruster
2026-09-29 15:03     ` John Snow
2026-09-29  6:32 ` [PATCH v3 00/10] qapi: convert/split remaining QAPI/QMP intro sections Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260928192557.509157-4-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=anisinha@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=farosas@suse.de \
    --cc=hreitz@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=jasowangio@gmail.com \
    --cc=kwolf@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=philmd@mailo.com \
    --cc=philmd@oss.qualcomm.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@yandex-team.ru \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.