From: Jakub Kicinski <kuba@kernel.org>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>,
Nicolai Buchwitz <nb@tipi-net.de>
Cc: netdev-bot+sashiko@kernel.org, davem@davemloft.net,
edumazet@kernel.org, pabeni@redhat.com, horms@kernel.org,
andrew@lunn.ch, kory.maincent@bootlin.com,
vadim.fedorenko@linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v3 2/2] net: ethtool: let tsconfig reach a PHY-only timestamp provider
Date: Mon, 28 Sep 2026 19:29:57 -0700 [thread overview]
Message-ID: <20260928192957.31dd51df@kernel.org> (raw)
In-Reply-To: <8100d62f-7615-4129-a633-7f4c7404a0e2@bootlin.com>
On Sat, 26 Sep 2026 20:03:14 +0200 Maxime Chevallier wrote:
> > There is no in-tree driver with ndo_hwtstamp_set but not _get. All 73 files
> > have them in pairs...
> >
> > Even further, the asymmetry is on purpose. The get side tests ndo_hwtstamp_get
> > and the set side tests ndo_hwtstamp_set, each gate testing what its own operation
> > needs.
> >
> > If anyone insists on the symmetry, a v4 could add || !ndo_hwtstamp_get. But before
> > I respin again, let's hear if this is really needed.
>
> The current way LGTM :)
Alright, but let's also follow up on this and add a check somewhere
during netdev registration to reject the asymmetric ops.
next prev parent reply other threads:[~2026-09-29 2:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260925135237.3432266-1-nb@tipi-net.de>
2026-09-25 13:52 ` [PATCH net v3 1/2] net: ethtool: reject an out of range hwtstamp provider index Nicolai Buchwitz
2026-09-25 13:55 ` Kory Maincent
2026-09-25 14:07 ` Nicolai Buchwitz
2026-09-25 17:57 ` Kory Maincent
2026-09-29 2:30 ` patchwork-bot+netdevbpf
2026-09-29 2:40 ` patchwork-bot+netdevbpf
2026-09-25 13:52 ` [PATCH net v3 2/2] net: ethtool: let tsconfig reach a PHY-only timestamp provider Nicolai Buchwitz
2026-09-26 13:54 ` netdev-bot+sashiko
2026-09-26 17:53 ` Nicolai Buchwitz
2026-09-26 18:03 ` Maxime Chevallier
2026-09-26 18:11 ` Nicolai Buchwitz
2026-09-29 2:29 ` Jakub Kicinski [this message]
2026-09-26 18:04 ` Maxime Chevallier
2026-09-27 16:00 ` Kory Maincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928192957.31dd51df@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=nb@tipi-net.de \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.