From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f12.google.com (mail-wm2-f12.google.com [74.125.225.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DE2E4F85C2 for ; Mon, 28 Sep 2026 20:54:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790628848; cv=none; b=EbX5O1Zu3EbQHpbAQt+QzhpZyPonA9E3GLedzxHw+DxdCMljIpQlVwexKiWKKK1UAnbxMZ9qYDPOvRICr8Yj2xQUqwuHufofidgn4jgHZhymi6BIDiFPc/7VHf1S4sK5nICRS1/ZX267iRDY/Hc4UCjUNmRGFYpyUkRpSaPegPY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790628848; c=relaxed/simple; bh=p4z8FqgH2wRH3DNXfLP/C8tVgznBcTgSwV5kisQHgOU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=sApG56YMj0HVl0F68JQiuGkZBErroZu3rI+Epzc5LU8SyqewcpQAUS9s009eMI6esMBER9tmX88ekR6Yf3BxDUhZ8wnye/hae3EfnvCgFBKD9H7n0eDGxWG48porwIfVmKVmiTPl0OYC0Ql4q9tAFLfVq/NkfQnhfhQedxDaiSY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nizLRGAa; arc=none smtp.client-ip=74.125.225.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nizLRGAa" Received: by mail-wm2-f12.google.com with SMTP id 5b1f17b1804b1-49ffa15f67fso13389165e9.2 for ; Mon, 28 Sep 2026 13:54:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790628844; x=1791233644; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MoftrO08HwDktpofinrTBCoRJxn64c18AOQxxmnppJw=; b=nizLRGAaKFUMCIahkZZE2GItc1v6vkpzHOzS/r8qI487Td6UTZcGg7REC555U9QtyX axizRcFPBZ6Lv5TYF102D2O1EDk/AdN3kkdXDKGwjHK7dok1oSa+qrAnAj5rM3uYg2+s 0QX9P+BRWYZj3N+9ReyoD87Go57wyskAS7KdvL6431DLvoX4V2u/bo5lBv+Y1QXY0yy3 /JE+5rV1jtMeCcQaPLPDZu1K+ELrv8L+WoSwIttqlheGpoZ+gX0SjBdBFDedGGOk7B8Q mZscQevshL2fGEbhAnD9mpcAqUWSorJyhn3lZoTUF0w9tuN8uMNaX9s2DLeTpNl2tToh RsiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790628844; x=1791233644; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=MoftrO08HwDktpofinrTBCoRJxn64c18AOQxxmnppJw=; b=yjznUXM6oTMs9aOLSimqIh0hRIzpDiV6Mekiq2jkN2bzDr0F7g/gNUiS9nLus1+Ycb qqytugOlVfV6vjh2KhcLWK3DBVz16gkGj6a5FHD3vsl72PvITUUTT9egIIfSCoyvRniK gcFFZ5AagEPSInO2R1dRddpwWDnq04pGoKjqFPEjJxHbu2VfzH5kIEs3bKoJLzZvxCqI l10rJwuFpT0i1hx69d9aF6J9OytJCA2tfaXhIzgmRyDm4iMnJ6JgEuh+eiEUShyqs3O/ 948QB5RY0FqN9VE4eGH7Sry9CH1btp4RMs6TjzVIupNg+tiE1JXLB1pyE2rMOH7FL7C4 SC8A== X-Forwarded-Encrypted: i=1; AKwUvBxknZhORmXNDBwSGl7t4YDuOg0hVydk1HBtdoUTqAEiLjwCQKpadf/vQK1TVEMvCIpsNAbCs34=@vger.kernel.org X-Gm-Message-State: AFuF++kFhQ/oxlH+YUkhIRlgEomZhKeSbxN8lOu6LyADwLq2DZ4Mv/1u +sEvnPXOdW82/zFfdUK4Ske95jRKb5o4o6NviqGUPL2J4f3K8tmNT0T4 X-Gm-Gg: AYBFou1h6Uyb1lOf6L/MkNf8l5hPpjIiK/V4r+pdXc1/rC1ewfhT1qK7KM4EkVm9SdM khQfSZy/iVkoGI9BXPVMVDkydTOeQrWWufhoRc6WYe7ioVrwMDhYoO92zin2oj/Y8Rtujziw71c qzfycaMUCXZTy2QYizBYCjFyQlpRtZqMgRv9pwdE7QkQyJmhOwN0znpCH9GAHD/QH6ndT+4e5Lx O8gnqMBK9QOW+px+92T/HtQbivFKIBaquLdoXCQB1/HC5LS51JvelgZCYKT4WI2OvjAqKEDtQXx 8pHekVvKP0cGXpCyiu0WUI9QD28sYQmIcUw0/FvjP3iObplBt9IKxv1lmNrvCl93t2vOW22kt4K VbXr2HjsmFD9ecoJmyuUvlefoRmTm5caZ7jRJwQk37Yc9IwOST0Z0coWYLt1CMwmk1k70Z08f8C 3zR0F6u4KuvgzSKoTvqflLBkOjrDrDK92B/kZ1+8M5M9EEAAeKUb3Rt48xZuRz8KU1Xka9Gdkvr ReBWP/Tr7AmkYdfnuZo8GDLGkRGeD7wujFFBHoFITGwle/h5YyY9JRQ37zs62RPwfmqmf5xssUo pCgUrkaK8YODD5BlSZoyCEW1Vw7BDjy5TKlcDNpQQ137raN5JhwlXegHhOfkIaQRdl73cS/Yoaz f4nompUmbODM= X-Received: by 2002:a05:600c:8a1a:20b0:49f:f0bd:1e40 with SMTP id 5b1f17b1804b1-49ff0bd1ea8mr133111765e9.23.1790628843492; Mon, 28 Sep 2026 13:54:03 -0700 (PDT) Received: from localhost.localdomain (dynamic-2a02-3100-acba-a601-4494-3582-465b-0eab.310.pool.telefonica.de. [2a02:3100:acba:a601:4494:3582:465b:eab]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a00d0f66cfsm21210805e9.14.2026.09.28.13.54.02 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 28 Sep 2026 13:54:03 -0700 (PDT) From: Karl Mehltretter To: Jeremy Kerr , Matt Johnston Cc: Karl Mehltretter , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , netdev@vger.kernel.org, Geert Uytterhoeven , Brendan Higgins , David Gow , Rae Moar , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2] net: mctp: Make KUnit tests depend on flow support Date: Mon, 28 Sep 2026 22:53:52 +0200 Message-Id: <20260928205352.30502-1-kmehltretter@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20260925192510.93840-1-kmehltretter@gmail.com> References: <20260925192510.93840-1-kmehltretter@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit MCTP_TEST selects MCTP_FLOWS, which also enables SKB_EXTENSIONS when no transport requires them. Enabling tests should not silently enable additional kernel functionality. Make the tests depend on MCTP_FLOWS instead, following the dependency rule in Documentation/dev-tools/kunit/style.rst. This keeps the full flow-test coverage: the suite is available only when flow support is enabled, for example by the I2C transport. Fixes: 109a5331143d ("net: mctp: tests: Test that outgoing skbs have flow data populated") Assisted-by: LLM Signed-off-by: Karl Mehltretter --- Changes in v2: - Depend on MCTP_FLOWS instead of removing the selection, as Jeremy requested, to retain full flow-test coverage. - Rebase onto current net-next (014d795c7383). v1: https://lore.kernel.org/r/20260925192510.93840-1-kmehltretter@gmail.com/ Review: https://lore.kernel.org/r/8edc4e71edceb124e2dca233cddb75e198b53a51.camel@codeconstruct.com.au/ Validation on net-next 014d795c7383: x86_64 GCC 15.2 builds and QEMU run. Both MCTP suites pass all 80 cases, including both flow tests, with no skips. Kconfig checks cover flow support on/off, KUNIT_ALL_TESTS on/off and a module I2C transport. net/mctp/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mctp/Kconfig b/net/mctp/Kconfig index d8d3413a37f7..e64d4f7ef6aa 100644 --- a/net/mctp/Kconfig +++ b/net/mctp/Kconfig @@ -14,7 +14,7 @@ menuconfig MCTP config MCTP_TEST bool "MCTP core tests" if !KUNIT_ALL_TESTS - select MCTP_FLOWS + depends on MCTP_FLOWS depends on MCTP=y && KUNIT=y default KUNIT_ALL_TESTS base-commit: 014d795c73837ea2339a4ea8e8f82c6e959b845d -- 2.39.5 (Apple Git-154)