Re: [PATCH v1 2/2] perf test: Improve JUnit XML schema compliance and completeness

[sashiko-bot@kernel.org]

> Improve the JUnit XML output generated by 'perf test -j' so that it
> validates cleanly against both the strict Apache Ant/Windy Road JUnit
> schema (JUnit.xsd) and the Jenkins xUnit/Maven Surefire schema
> (junit-10.xsd):
> - Add the required 'package', 'id', 'timestamp' (ISO 8601 UTC),
>   'hostname', and 'time' attributes to '<testsuite>'.
> - Emit '<properties>' (populated with uname sysname, release, version,
>   and machine when available) at the start of '<testsuite>' and
>   '<system-out/>' and '<system-err/>' at the end, matching the element
>   sequence required by JUnit.xsd.
> - Add the required 'type="failure"' attribute to '<failure>' elements
>   and emit self-closing tags for passing '<testcase>' elements and
>   '<failure>'/'<error>' elements with empty error output.
> - Escape apostrophes ('&apos;') and validate UTF-8 multi-byte sequences
>   against valid XML 1.0 codepoints in xml_escape().
> - Use the actual suite description and '%.2f' time format for user
>   override skipped tests ('-s'/'--skip').
> - Document '-j[<file>]'/'--junit[=<file>]' in perf-test.txt.
> 
> Assisted-by: Antigravity:gemini-3.1-pro
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928210144.3925224-1-irogers@google.com?part=2