From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7220CA5FA5 for ; Tue, 29 Sep 2026 02:16:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NA0QmtsolUo6gB2GU0GCy6kSebVzmv+RRyY8jE6s28I=; b=DMBizEQGKEAPsq SdT+H+HAehMbNgIxY3+fmBsSUWhwDoaZtDua5Mw4JNavAk1losEc5lGA6IIElN5B/i5ggJu8ork9O 5sMAxzDJ7I8AH1TjnwPht2EbFavwQWtR/d9XKCiGXeCVnDofmo7IUzAO7Cp7HfBY7ashhz+smu5WT ELqfSRt8dihvc5sTRTFKmxNwxMJFRJZr3Ht97stGfbrtePGcHh76vZ3BeBTOBZoW/HWa8i+LlU+pg bLCFByQfoy+jyZGGL5sjM89xlsrG1vYSb6pWJNJfWmWtyJdHGJtooloVq52XrkfVVF194JuVza1SG qZN/E/zqfIAMBNUXCgJA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xBNOB-000000027BZ-1pH3; Tue, 29 Sep 2026 02:16:15 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xBNOA-000000027B7-0aOA for linux-phy@lists.infradead.org; Tue, 29 Sep 2026 02:16:14 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 3B7C760008; Tue, 29 Sep 2026 02:16:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7EB891F000FF; Tue, 29 Sep 2026 02:16:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790648172; bh=zwl3tTzOXIR9Std1UeTK2RA1IHFZWaJIg+6cKzNqwAA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=H8i3f/v3qxfYK+6vAShGxs93raIuac5bE6cIUbsN1uzYGl93AWRBVP0fb+y0uuTGZ jVgHzPDHqxakogDsoDnE4iAtn3xbI/ODAseUwNvPnq6TMDYcLpiPawTdsrnaDjVLOO PKDpRS9FHVLOEpx46zKE5yIJFYNnGOerQUmPByz1AR5sYeB0q2AnmSWhq/7Tm5uCUO zLrV6vZcYLiZ8UiNze8sVVIX1dP2DO0ObKyxkXrbYsrHIthX6luKzqwF9aQkkvZ8ze vmyCUUXTpQ7NTLPJWT/+nI4W7ICjAEdAUkm3VDmtHvPZc4s9XxGF+zwHInzYeWmtlF 2bPD7BmUE+Dzg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v6 3/3] phy: nuvoton: phy-ma35d1-usb2: extend to dual-port with OTG support To: "Joey Lu" Cc: vkoul@kernel.org, robh@kernel.org, neil.armstrong@linaro.org, devicetree@vger.kernel.org, conor+dt@kernel.org, olteanv@gmail.com, linux-phy@lists.infradead.org In-Reply-To: <20260929020854.1282339-4-a0987203069@gmail.com> References: <20260929020854.1282339-1-a0987203069@gmail.com> <20260929020854.1282339-4-a0987203069@gmail.com> Date: Tue, 29 Sep 2026 02:16:12 +0000 Message-Id: <20260929021612.7EB891F000FF@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gcGh5OiBudXZvdG9u OiB1bmluaXRpYWxpemVkIHN0YWNrIHZhcmlhYmxlIHVzYWdlIGluIG1hMzVfcm9sZV9zd19nZXQo KQotLQoKY29tbWl0IDgwMWExMjM0NjZhNTcyYWEwNzBmZDdhODg1YmIyN2FkZjNmODMxMTAKQXV0 aG9yOiBKb2V5IEx1IDxhMDk4NzIwMzA2OUBnbWFpbC5jb20+CgpwaHk6IG51dm90b246IHBoeS1t YTM1ZDEtdXNiMjogZXh0ZW5kIHRvIGR1YWwtcG9ydCB3aXRoIE9URyBzdXBwb3J0CgpUaGlzIGNv bW1pdCBleHRlbmRzIHRoZSBOdXZvdG9uIE1BMzVEMSBVU0IgMi4wIFBIWSBkcml2ZXIgdG8gbWFu YWdlIGJvdGgKUEhZMCBhbmQgUEhZMSwgaGFuZGxpbmcgaG9zdCBhbmQgZGV2aWNlIG1vZGVzLiBJ dCBpbnRyb2R1Y2VzIGEgc2luZ2xlIGluaXQKY2FsbGJhY2sgaW5zdGVhZCBvZiBzZXBhcmF0ZSBw b3dlcl9vbi9wb3dlcl9vZmYgY2FsbGJhY2tzIGFuZCBhZGRzIGEgVVNCCnJvbGUgc3dpdGNoIGZv ciBQSFkwLiBOZXcgZGV2aWNlLXRyZWUgcHJvcGVydGllcyBmb3IgcmVzaXN0b3IgY2FsaWJyYXRp b24KYW5kIG92ZXItY3VycmVudCBwb2xhcml0eSBhcmUgYWxzbyBzdXBwb3J0ZWQuCgo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL3BoeS9udXZvdG9uL3BoeS1tYTM1ZDEtdXNiMi5jIGIvZHJpdmVycy9w aHkvbnV2b3Rvbi9waHktbWEzNWQxLXVzYjIuYwo+IGluZGV4IDlhNDU5YjcwMGVkNDguLjU0N2M3 ZDU1ZDhmZjQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9waHkvbnV2b3Rvbi9waHktbWEzNWQxLXVz YjIuYwo+ICsrKyBiL2RyaXZlcnMvcGh5L251dm90b24vcGh5LW1hMzVkMS11c2IyLmMKWyAuLi4g XQo+ICtzdGF0aWMgZW51bSB1c2Jfcm9sZSBtYTM1X3JvbGVfc3dfZ2V0KHN0cnVjdCB1c2Jfcm9s ZV9zd2l0Y2ggKnN3KQo+ICt7Cj4gKwlzdHJ1Y3QgbWEzNV91c2JfcGh5ICpwID0gdXNiX3JvbGVf c3dpdGNoX2dldF9kcnZkYXRhKHN3KTsKPiArCXUzMiB2YWw7Cj4gKwo+ICsJcmVnbWFwX3JlYWQo cC0+c3lzcmVnLCBNQTM1X1NZU19QV1JPTk9UUCwgJnZhbCk7Cj4gKwo+ICsJcmV0dXJuICh2YWwg JiBQV1JPTk9UUF9VU0JQMElEKSA/IFVTQl9ST0xFX0hPU1QgOiBVU0JfUk9MRV9ERVZJQ0U7Cj4g K30KCltTZXZlcml0eTogTWVkaXVtXQpEb2VzIHRoaXMgY29kZSB1c2UgYW4gdW5pbml0aWFsaXpl ZCBzdGFjayB2YXJpYWJsZSBpZiByZWdtYXBfcmVhZCgpIGZhaWxzPwoKSWYgcmVnbWFwX3JlYWQo KSByZXR1cm5zIGEgbmVnYXRpdmUgZXJyb3IgY29kZSwgdGhlIG91dC1wYXJhbWV0ZXIgdmFsIHdp bGwKcmVtYWluIHVuaW5pdGlhbGl6ZWQuIFRoZSBzdWJzZXF1ZW50IGNoZWNrIG9mIHZhbCAmIFBX Uk9OT1RQX1VTQlAwSUQgd291bGQKdGhlbiBldmFsdWF0ZSB1bmluaXRpYWxpemVkIGtlcm5lbCBz dGFjayBtZW1vcnkuCgpUaGlzIGNvdWxkIHJlcG9ydCBhbiB1bnJlbGlhYmxlIGhhcmR3YXJlIHN0 YXRlIHRvIHRoZSBVU0Igcm9sZSBmcmFtZXdvcmsgYW5kCmxlYWsgYSBiaXQgb2Yga2VybmVsIHN0 YWNrIG1lbW9yeSB0byB1c2Vyc3BhY2UgdmlhIHRoZSBzeXNmcyBpbnRlcmZhY2UuCgotLSAKU2Fz aGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIwMjYwOTI5 MDIwODU0LjEyODIzMzktMS1hMDk4NzIwMzA2OUBnbWFpbC5jb20/cGFydD0zCgotLSAKbGludXgt cGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BD011C5F1B for ; Tue, 29 Sep 2026 02:16:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790648174; cv=none; b=YN2OaOlZaSU9c6Z0tm+H871wiqmJQD1v74n2NMbXIOmRSbix9K6rDarj5kBwFR9Vpy/yVa8Al9UNHqBZtpDcBdI1c+9fN4f3UnYlZsjAsGTIMijnfojlG9d/syMqXifYe93vbXyU8AC/MUMZ83JHvBX1tvotqe2mO0b0l3kJjfs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790648174; c=relaxed/simple; bh=HGacQfhtXMtID5jIwejDZHJQm2A1yH08CfjD3/x6loc=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=FuKM4zQRuZjAikgix1A/hZ01pwhKGtGFxTMNg1xHPyazriQxKmUTsZIa2iLg3/pUioHex0VJO58TZ6SubRmZhQDz4SxsUu74fiiC4bnzktXyZ4XTqyLTS3WAv2ytKMJG78zbZM3G9qEJry7pCe9qhsfrlftLo9db5SFchqBXnLU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=H8i3f/v3; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="H8i3f/v3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7EB891F000FF; Tue, 29 Sep 2026 02:16:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790648172; bh=zwl3tTzOXIR9Std1UeTK2RA1IHFZWaJIg+6cKzNqwAA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=H8i3f/v3qxfYK+6vAShGxs93raIuac5bE6cIUbsN1uzYGl93AWRBVP0fb+y0uuTGZ jVgHzPDHqxakogDsoDnE4iAtn3xbI/ODAseUwNvPnq6TMDYcLpiPawTdsrnaDjVLOO PKDpRS9FHVLOEpx46zKE5yIJFYNnGOerQUmPByz1AR5sYeB0q2AnmSWhq/7Tm5uCUO zLrV6vZcYLiZ8UiNze8sVVIX1dP2DO0ObKyxkXrbYsrHIthX6luKzqwF9aQkkvZ8ze vmyCUUXTpQ7NTLPJWT/+nI4W7ICjAEdAUkm3VDmtHvPZc4s9XxGF+zwHInzYeWmtlF 2bPD7BmUE+Dzg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v6 3/3] phy: nuvoton: phy-ma35d1-usb2: extend to dual-port with OTG support Reply-To: sashiko-reviews@lists.linux.dev To: "Joey Lu" Cc: vkoul@kernel.org, robh@kernel.org, neil.armstrong@linaro.org, devicetree@vger.kernel.org, conor+dt@kernel.org, olteanv@gmail.com, linux-phy@lists.infradead.org In-Reply-To: <20260929020854.1282339-4-a0987203069@gmail.com> References: <20260929020854.1282339-1-a0987203069@gmail.com> <20260929020854.1282339-4-a0987203069@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 29 Sep 2026 02:16:12 +0000 Message-Id: <20260929021612.7EB891F000FF@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] phy: nuvoton: uninitialized stack variable usage in ma35_role_sw= _get() -- commit 801a123466a572aa070fd7a885bb27adf3f83110 Author: Joey Lu phy: nuvoton: phy-ma35d1-usb2: extend to dual-port with OTG support This commit extends the Nuvoton MA35D1 USB 2.0 PHY driver to manage both PHY0 and PHY1, handling host and device modes. It introduces a single init callback instead of separate power_on/power_off callbacks and adds a USB role switch for PHY0. New device-tree properties for resistor calibration and over-current polarity are also supported. > diff --git a/drivers/phy/nuvoton/phy-ma35d1-usb2.c b/drivers/phy/nuvoton/= phy-ma35d1-usb2.c > index 9a459b700ed48..547c7d55d8ff4 100644 > --- a/drivers/phy/nuvoton/phy-ma35d1-usb2.c > +++ b/drivers/phy/nuvoton/phy-ma35d1-usb2.c [ ... ] > +static enum usb_role ma35_role_sw_get(struct usb_role_switch *sw) > +{ > + struct ma35_usb_phy *p =3D usb_role_switch_get_drvdata(sw); > + u32 val; > + > + regmap_read(p->sysreg, MA35_SYS_PWRONOTP, &val); > + > + return (val & PWRONOTP_USBP0ID) ? USB_ROLE_HOST : USB_ROLE_DEVICE; > +} [Severity: Medium] Does this code use an uninitialized stack variable if regmap_read() fails? If regmap_read() returns a negative error code, the out-parameter val will remain uninitialized. The subsequent check of val & PWRONOTP_USBP0ID would then evaluate uninitialized kernel stack memory. This could report an unreliable hardware state to the USB role framework and leak a bit of kernel stack memory to userspace via the sysfs interface. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260929020854.1282= 339-1-a0987203069@gmail.com?part=3D3