Re: [PATCH 1/2] arm64: dts: exynos850: Add ACPM firmware node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: exynos850: undefined phandles ap2apm_mailbox and apm_sram
--

commit 66e41f222fe556cc663cc05ae12d7a66bb68f527
Author: Alexey Klimov <alexey.klimov@linaro.org>

arm64: dts: exynos850: Add ACPM firmware node

Add the ACPM firmware node with cpucl0 and cpucl1 clocks. This provides an
interface for client drivers to use features exposed by the APM
co-processor.

> diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi
> index 911643008b9f5..199f96f9daa2e 100644
> --- a/arch/arm64/boot/dts/exynos/exynos850.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi

[ ... ]

> @@ -170,6 +171,18 @@ timer {
>  		     <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>;
>  	};
>  
> +	firmware {
> +		acpm_ipc: power-management {
> +			compatible = "samsung,exynos850-acpm-ipc";
> +			mboxes = <&ap2apm_mailbox>;
> +			shmem = <&apm_sram>;

[Severity: Low]
Are the ap2apm_mailbox and apm_sram node labels defined in this tree?

In the acpm_ipc node of exynos850.dtsi, a search across the file and its
board files doesn't show definitions for these labels. Referencing them
causes a dtc build regression with a phandle_references error.

Are these definitions missing from the patch?

> +			clocks = <&cmu_cpucl0 CLK_FOUT_CPUCL0_PLL>,
> +				 <&cmu_cpucl1 CLK_FOUT_CPUCL1_PLL>;
> +			clock-names = "cpucl0", "cpucl1";
> +			#clock-cells = <1>;
> +		};
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260929-exynos850-acpm-node-cpufreq-v1-0-5a86c1d404b8@linaro.org?part=1