Re: [PATCH RFC 07/10] firmware: riscv: rpmi-tee: discover TEE services

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] rpmi_tee: mixed goto-based error handling with scope-based cleanup
--

commit 6089779ce1ff0f765c5a7729a4fc32fd807d547b
Author: Amirreza Zarrabi <amirreza.zarrabi@oss.qualcomm.com>

firmware: riscv: rpmi-tee: discover TEE services

This commit adds the RPMI TEE service-group message layer to discover
endpoints and services. It introduces requests to probe features and system
info, and registers one RPMI TEE device for each discovered service.

> diff --git a/drivers/firmware/riscv_rpmi_tee/driver.c b/drivers/firmware/riscv_rpmi_tee/driver.c
> --- a/drivers/firmware/riscv_rpmi_tee/driver.c
> +++ b/drivers/firmware/riscv_rpmi_tee/driver.c

[ ... ]

> +static int
> +rpmi_tee_register_devices(struct rpmi_tee_transport *priv,
> +			  const struct rpmi_tee_sysinfo_service_info *services,
> +			  size_t service_count)
> +{
> +	size_t i;
> +	int ret;
> +
> +	for (i = 0; i < service_count; i++) {
> +		const struct rpmi_tee_sysinfo_service_info *service = &services[i];
> +
> +		/* Discard duplicate devices in the same endpoint. */
> +		if (rpmi_tee_find_device(priv, &service->uuid,
> +					 service->endpoint_id))
> +			continue;
> +
> +		struct rpmi_tee_child *child __free(kfree) =
> +			kzalloc_obj(*child, GFP_KERNEL);
> +		if (!child) {
> +			ret = -ENOMEM;
> +			goto err_unregister;

[Severity: Low]
Does this code mix goto-based error handling with scope-based cleanup?

The kernel cleanup guidelines state that the usage of goto and cleanup
helpers like __free() should not be mixed in the same function to prevent
complex ownership semantics. Should rpmi_tee_register_devices() be updated
to either use only goto labels or exclusively scope-based cleanup for its
error paths?

> +		}
> +		child->rdev = rpmi_tee_device_register(&service->uuid,
> +						       service->endpoint_id,
> +						       &rpmi_tee_ops,
> +						       priv->dev);
> +		if (IS_ERR(child->rdev)) {
> +			ret = PTR_ERR(child->rdev);
> +			goto err_unregister;
> +		}
> +
> +		list_add_tail(&no_free_ptr(child)->node, &priv->devices);
> +	}
> +
> +	return 0;
> +
> +err_unregister:
> +	rpmi_tee_unregister_devices(priv);
> +
> +	return ret;
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928-riscv-rpmi-tee-abi-v1-0-04908b81d885@oss.qualcomm.com?part=7