From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-97.freemail.mail.aliyun.com (out30-97.freemail.mail.aliyun.com [115.124.30.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AB6D3911AB; Tue, 29 Sep 2026 03:40:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.97 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790653235; cv=none; b=OP4pvjIEogwJzasmkjy4L5eDcBLWhvBrpK13Is19zSBxQTSxd4fN+o8R4J4Yhq7sRBFsNGU7tA+5SxJLqjyB3uAiImxbRE15MWH7p2aRn6JAblt0KYA2xcx0Vz0fmtvOxlzu6Q3H9ES+X6i1SCN8Hx58NU8pOEdtq2RFI5gMPZ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790653235; c=relaxed/simple; bh=qXy2sRf3UPjdIHWylaXPiQGMJd9HqpbGIqCOgYXTgM0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GfrBLg/z5R0jfHMIQiyYDP1eMt746WSJ7NC74+xK0RFuJV6hm6V+sYdmH5H3ISkg5JL8+ciptaH7NMpcXhR42/gA8GxIND3Q9PE1uv/7pzwIms8h3+FEl68MCvtj1LW5S/u5bdr6HbKpvQNTWxUjO5U4M1aI4mHS14JC3GtKl3E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=h5wUwGlF; arc=none smtp.client-ip=115.124.30.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="h5wUwGlF" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1790653223; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=qXy2sRf3UPjdIHWylaXPiQGMJd9HqpbGIqCOgYXTgM0=; b=h5wUwGlF8mWNI5ZH5ykL/+1H/DUmkkV+XsPE0kCcNwcVye+wBwp11KLUkyo0feRXJ1VVAYdiwDTTH4WGLuABi4QhkCH7JRMJhWhOmmokaMe1llqGPvrse+Qg6PZt/XsrwcfcpgWQ56X+BhYwcqLZZYk8HGBzmJ2ACdCQD1r0BYs= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037033178;MF=cp0613@linux.alibaba.com;NM=1;PH=DS;RN=21;SR=0;TI=SMTPD_---0XBrsUfB_1790653212; Received: from DESKTOP-S9E58SO.localdomain(mailfrom:cp0613@linux.alibaba.com fp:SMTPD_---0XBrsUfB_1790653212 cluster:ay36) by smtp.aliyun-inc.com; Tue, 29 Sep 2026 11:40:21 +0800 From: Chen Pei To: Leo Yan Cc: acme@kernel.org, peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, james.clark@linaro.org, john.g.garry@oracle.com, will@kernel.org, mike.leach@arm.com, pjw@kernel.org, palmer@dabbelt.com, guoren@kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] perf tsc: Replace the compile-time TSC support check with a weak hook Date: Tue, 29 Sep 2026 11:40:11 +0800 Message-ID: <20260929034013.2110-1-cp0613@linux.alibaba.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260928163442.GG14479@e132581.arm.com> References: <20260928094739.2605-1-cp0613@linux.alibaba.com> <20260928094739.2605-3-cp0613@linux.alibaba.com> <20260928163442.GG14479@e132581.arm.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Leo, Thanks a lot for the review. > Just a bit on refactoring. You could refer to the implementation of > PERF_HAVE_JITDUMP in arch Makefile and "CFLAGS += -DHAVE_JITDUMP" and > do similiar thing for rdtsc. > > Seems to me, we can just use build system for configurations. Makes sense, I'll change it that way in v2, thanks for pointing at the existing pattern. Best regards, Pei From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73968C9832A for ; Tue, 29 Sep 2026 03:40:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XObidRTvYhqXtkR6SFsiED9yDSzfA9UdygsxUwhaMpk=; b=QPqKAL8P9xYwDO ZOeggAxCztEPH5QYk810jp84+RaG2v+deIZ4luk484n7rAKRafF1/Rbp2P3FBIsXK6nN2oykTRoa3 yMwHv9txr09aFQ7UUK7xFd5oUxNlZTghv5sG+v2itgevtxnDiuDHIEOvKzTCMGvKjwXjWl9sDyAuj GbswCSmC9XnYUT17IpNRD2k6fB4diO4bJbpy2N1Ef7dhKIkscgFHA5pwYLUnZ/+m5MvV+9oGrassL 4ZyDwm6tu1ODnX6ScFNl9L8YCWe8jwNjXEPufBoDbhb26ljEyorq5+eQn3oCJWIrPKgNhqn5OGQmh tjF/oly/Y0GcOTJdcdaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xBOhj-00000002EoE-3SBB; Tue, 29 Sep 2026 03:40:31 +0000 Received: from out30-98.freemail.mail.aliyun.com ([115.124.30.98]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xBOhg-00000002Emx-1Da4; Tue, 29 Sep 2026 03:40:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1790653222; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=qXy2sRf3UPjdIHWylaXPiQGMJd9HqpbGIqCOgYXTgM0=; b=O7E1oVIvEdiPqu+At1cihpzIAXw1IjdBeKSW9MU2ZDEcRHa7BHHO4pmx9xeWtHvalpgQOUnqSOPpaFnpYWrAEmw8rJl1ReUy//YI1WL/J/N8sRXHyBmPsqqGy5POcQPjGjkfTJjty4lTUhmw/D92x1cN3vcm3lxyFYwpmkUvEko= X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037033178;MF=cp0613@linux.alibaba.com;NM=1;PH=DS;RN=21;SR=0;TI=SMTPD_---0XBrsUfB_1790653212; Received: from DESKTOP-S9E58SO.localdomain(mailfrom:cp0613@linux.alibaba.com fp:SMTPD_---0XBrsUfB_1790653212 cluster:ay36) by smtp.aliyun-inc.com; Tue, 29 Sep 2026 11:40:21 +0800 From: Chen Pei To: Leo Yan Cc: acme@kernel.org, peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, james.clark@linaro.org, john.g.garry@oracle.com, will@kernel.org, mike.leach@arm.com, pjw@kernel.org, palmer@dabbelt.com, guoren@kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] perf tsc: Replace the compile-time TSC support check with a weak hook Date: Tue, 29 Sep 2026 11:40:11 +0800 Message-ID: <20260929034013.2110-1-cp0613@linux.alibaba.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260928163442.GG14479@e132581.arm.com> References: <20260928094739.2605-1-cp0613@linux.alibaba.com> <20260928094739.2605-3-cp0613@linux.alibaba.com> <20260928163442.GG14479@e132581.arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260928_204028_654034_9A9F250B X-CRM114-Status: UNSURE ( 8.40 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi Leo, Thanks a lot for the review. > Just a bit on refactoring. You could refer to the implementation of > PERF_HAVE_JITDUMP in arch Makefile and "CFLAGS += -DHAVE_JITDUMP" and > do similiar thing for rdtsc. > > Seems to me, we can just use build system for configurations. Makes sense, I'll change it that way in v2, thanks for pointing at the existing pattern. Best regards, Pei _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv