From: Ruslan Koreev <koreev.r@gmail.com>
To: sakari.ailus@linux.intel.com, benjamin.mugnier@foss.st.com,
sylvain.petinot@foss.st.com, dan.scally@ideasonboard.com
Cc: mchehab@kernel.org, hansg@kernel.org,
ilpo.jarvinen@linux.intel.com, linux-media@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org,
Peter Marshall <pm@petermarshall.ca>,
Ruslan Koreev <koreev.r@gmail.com>
Subject: [PATCH v2 3/4] media: i2c: vd55g1: Return the endpoint parser's error code
Date: Tue, 29 Sep 2026 12:27:00 +0300 [thread overview]
Message-ID: <20260929092700.1776966-5-koreev.r@gmail.com> (raw)
In-Reply-To: <20260929092700.1776966-1-koreev.r@gmail.com>
Pass the endpoint to v4l2_fwnode_endpoint_alloc_parse() without checking
it first and return the parser's error code instead of -EINVAL. The
parser returns -EPROBE_DEFER for a missing endpoint, which is what a
sensor on an ACPI system needs: there the endpoint is a software node
that the IPU bridge attaches when the IPU driver probes, possibly after
this driver. On OF systems a missing endpoint now defers the probe as
well instead of failing it, as in other sensor drivers that leave this
check to the parser.
Signed-off-by: Ruslan Koreev <koreev.r@gmail.com>
---
drivers/media/i2c/vd55g1.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c
index 22b1497e8..8043eaa50 100644
--- a/drivers/media/i2c/vd55g1.c
+++ b/drivers/media/i2c/vd55g1.c
@@ -1801,7 +1801,7 @@ static int vd55g1_check_csi_conf(struct vd55g1 *sensor,
ret = v4l2_fwnode_endpoint_alloc_parse(endpoint, &ep);
if (ret)
- return -EINVAL;
+ return ret;
/* Check lanes number */
n_lanes = ep.bus.mipi_csi2.num_data_lanes;
@@ -1905,11 +1905,6 @@ static int vd55g1_parse_dt(struct vd55g1 *sensor)
endpoint = fwnode_graph_get_endpoint_by_id(dev_fwnode(sensor->dev),
0, 0, 0);
- if (!endpoint) {
- dev_err(sensor->dev, "Endpoint node not found\n");
- return -EINVAL;
- }
-
ret = vd55g1_check_csi_conf(sensor, endpoint);
fwnode_handle_put(endpoint);
if (ret)
--
2.55.0
next prev parent reply other threads:[~2026-09-29 9:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 9:26 [PATCH v2 0/4] Lenovo ThinkPad X1 Carbon Gen 14 IR camera: ST VD55G1 on Intel IPU7 Ruslan Koreev
2026-09-29 9:26 ` [PATCH v2 1/4] platform/x86: int3472: Map the VD55G1 power enable GPIO to "vana" Ruslan Koreev
2026-09-29 9:26 ` [PATCH v2 2/4] media: ipu-bridge: Add the ST VD55G1 (TBE20A1) Ruslan Koreev
2026-09-29 9:27 ` Ruslan Koreev [this message]
2026-09-30 7:57 ` [PATCH v2 3/4] media: i2c: vd55g1: Return the endpoint parser's error code Benjamin Mugnier
2026-09-29 9:27 ` [PATCH v2 4/4] media: i2c: vd55g1: Add ACPI support Ruslan Koreev
2026-09-30 7:58 ` Benjamin Mugnier
2026-10-03 10:04 ` [PATCH v2 0/4] Lenovo ThinkPad X1 Carbon Gen 14 IR camera: ST VD55G1 on Intel IPU7 Qiling Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929092700.1776966-5-koreev.r@gmail.com \
--to=koreev.r@gmail.com \
--cc=benjamin.mugnier@foss.st.com \
--cc=dan.scally@ideasonboard.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pm@petermarshall.ca \
--cc=sakari.ailus@linux.intel.com \
--cc=sylvain.petinot@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.