Re: [PATCH 1/4] regulator: of: fill in supply names in of_regulator_bulk_get_all()

[sashiko-bot@kernel.org]

> of_regulator_bulk_get_all() returns an array it allocated itself, and
> fills in only the consumer of each entry. Every other way of getting a
> bulk array has the supply name set, because the caller provides it, and
> the core expects it to be there: regulator_bulk_enable() prints it when
> a supply fails to enable, so a caller that hands such an array to it
> dereferences uninitialised memory on that path.
> 
> Copy each name into the array's own allocation, right behind the
> entries, so that it shares the array's lifetime and callers still have
> nothing extra to free. That also retires the fixed 64 byte stack buffer
> the names were assembled in, which is_supply_name() never bounded the
> copy against.
> 
> Cc: stable@vger.kernel.org
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Closes: https://sashiko.dev/#/patchset/20260928-b4-rk3576-reboot-mode-v1-0-65486b03bd41@flipper.net?part=3
> Fixes: 27b9ecc7a9ba ("regulator: Add of_regulator_bulk_get_all")
> Signed-off-by: Alexey Charkov <alchark@flipper.net>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260929-regulator-get-all-v1-0-e887c66a47f1@flipper.net?part=1