From: sashiko-bot@kernel.org
To: "Kaiqi Guo" <chaoji_xinren@163.com>
Cc: "Danilo Krummrich" <dakr@kernel.org>,
"Alexandre Courbot" <acourbot@nvidia.com>,
gary@garyguo.net, dri-devel@lists.freedesktop.org,
ojeda@kernel.org
Subject: Re: [PATCH v6 08/10] rust: macros: test exhaustive conversion derives
Date: Tue, 29 Sep 2026 14:07:02 +0000 [thread overview]
Message-ID: <20260929140702.812561F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260929135855.36775-9-chaoji_xinren@163.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] rust: macros: non-vertical import formatting in doc tests
--
commit b361cafb4eb66d1f226f7d0ead63f4a791967d6c
Author: Kaiqi Guo <chaoji_xinren@163.com>
rust: macros: test exhaustive conversion derives
This commit adds extensive tests for From, Into, and TryFrom exhaustive
conversion derives. It covers bounded ranges, boolean, full-width primitives,
and verifies various compile-time error cases for incomplete domains and
invalid layouts.
> diff --git a/rust/macros/convert.rs b/rust/macros/convert.rs
> index 7fa8a22dc9133..c23b8819572e3 100644
> --- a/rust/macros/convert.rs
> +++ b/rust/macros/convert.rs
> @@ -1671,3 +1671,375 @@ mod overflow_assert_works_on_unsigned_int {}
> /// ```
> mod any_try_from_target_overflow_is_rejected {}
> }
> +
> +mod derive_from_tests {
> + /// ```
> + /// use kernel::{macros::{From, Into}, num::Bounded};
[Severity: Low]
Does this import (and others in the added doc tests) violate the kernel's
vertical import style guidelines? The Rust subsystem guidelines require
vertical trailing-comma syntax for imports, but this uses horizontal grouping.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260929135855.36775-1-chaoji_xinren@163.com?part=8
next prev parent reply other threads:[~2026-09-29 14:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 13:58 [PATCH v6 00/10] rust: add conversion derives and exhaustive From support Kaiqi Guo
2026-09-29 13:58 ` [PATCH v6 01/10] rust: macros: add derive macro for `Into` Kaiqi Guo
2026-09-29 14:10 ` sashiko-bot
2026-09-29 13:58 ` [PATCH v6 02/10] rust: macros: add derive macro for `TryFrom` Kaiqi Guo
2026-09-29 14:10 ` sashiko-bot
2026-09-29 13:58 ` [PATCH v6 03/10] rust: macros: add `convert` helper attribute Kaiqi Guo
2026-09-29 13:58 ` [PATCH v6 04/10] rust: macros: add private doctests for `Into` derive macro Kaiqi Guo
2026-09-29 13:58 ` [PATCH v6 05/10] rust: macros: add private doctests for `TryFrom` " Kaiqi Guo
2026-09-29 13:58 ` [PATCH v6 06/10] rust: macros: exercise the intended conversion doctest failures Kaiqi Guo
2026-09-29 18:47 ` Miguel Ojeda
2026-09-29 13:58 ` [PATCH v6 07/10] rust: macros: derive From for exhaustive enum conversions Kaiqi Guo
2026-09-29 13:58 ` [PATCH v6 08/10] rust: macros: test exhaustive conversion derives Kaiqi Guo
2026-09-29 14:07 ` sashiko-bot [this message]
2026-09-29 13:58 ` [PATCH v6 09/10] rust: macros: validate and qualify conversion helper types Kaiqi Guo
2026-09-29 13:58 ` [PATCH v6 10/10] gpu: nova-core: use conversion derives for two register enums Kaiqi Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929140702.812561F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=acourbot@nvidia.com \
--cc=chaoji_xinren@163.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=ojeda@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.