Re: [RFC PATCH v3 3/3] arm64: dts: rockchip: fix power-off on Firefly-RK3399

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] dts: rockchip: brittle power-off reliance on pwm-backlight shutdown
--

commit 33bb2c6f679e2298d49b0a4f468566e0d2a12e3c
Author: Yaozhong Li <yaozhonguwl@gmail.com>

arm64: dts: rockchip: fix power-off on Firefly-RK3399

This commit configures the power-hold-gpios for the RK808 PMIC on the
Firefly-RK3399 board to prevent it from rebooting instead of staying off.
It relies on the pwm-backlight driver to handle the release of GPIO1_B5.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts b/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts
> index 0568dfa140b32..210e4cbb656ce 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts
> @@ -327,6 +327,8 @@ rk808: pmic@1b {
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&pmic_int_l>;
>  		system-power-controller;
> +		power-hold-gpios = <&gpio1 RK_PD0 GPIO_ACTIVE_HIGH>;

[Severity: High]
Is it safe to omit the hardware-required GPIO1_B5 from the PMIC's power-off
logic?

The commit message notes that the board will come back up if GPIO1_B5 is still
high when the shutdown bit is written. By delegating this core power-off
requirement to the optional pwm-backlight driver, could the board reboot
instead of powering off if the backlight driver is inactive?

This might happen if CONFIG_BACKLIGHT_PWM is disabled, the driver fails to
probe, or an emergency panic skips device_shutdown().

> +		power-hold-delay-ms = <200>;
>  		wakeup-source;
>  
>  		vcc1-supply = <&vcc_sys>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260929140649.55-1-yaozhonguwl@gmail.com?part=3