From: Jakub Kicinski <kuba@kernel.org>
To: Aleksei Sviridkin <f@lex.la>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Mao Wenan <maowenan@huawei.com>,
Woojung Huh <woojung.huh@microchip.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>
Subject: Re: [PATCH net v3 3/4] net: phy: serialise attach and detach with PHY driver bind and unbind
Date: Tue, 29 Sep 2026 17:46:19 -0700 [thread overview]
Message-ID: <20260929174619.727bde40@kernel.org> (raw)
In-Reply-To: <20260924215951.2127682-4-f@lex.la>
On Fri, 25 Sep 2026 00:59:49 +0300 Aleksei Sviridkin wrote:
> /**
> - * phy_probe - probe and init a PHY device
> + * __phy_probe - probe and init a PHY device
> * @dev: device to probe and init
> *
> * Take care of setting up the phy_device structure, set the state to READY.
> */
> -static int phy_probe(struct device *dev)
> +static int __phy_probe(struct device *dev)
You're touching it, you need to make the kdoc fully valid:
Warning: drivers/net/phy/phy_device.c:3709 No description found for return value of '__phy_probe'
> +static int __phy_probe(struct device *dev);
the forward declaration is unavoidable? we can't reorder?
--
pw-bot: cr
next prev parent reply other threads:[~2026-09-30 0:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 21:59 [PATCH net v3 0/4] net: phy: make PHY driver unbind safe against attach and use Aleksei Sviridkin
2026-09-24 21:59 ` [PATCH net v3 1/4] net: phy: refuse a second attach before touching the PHY Aleksei Sviridkin
2026-09-24 21:59 ` [PATCH net v3 2/4] net: phy: put the driver module the attach took Aleksei Sviridkin
2026-09-24 21:59 ` [PATCH net v3 3/4] net: phy: serialise attach and detach with PHY driver bind and unbind Aleksei Sviridkin
2026-09-30 0:46 ` Jakub Kicinski [this message]
2026-09-24 21:59 ` [PATCH net v3 4/4] net: phy: make an unbind wait for the attached consumer to detach Aleksei Sviridkin
2026-09-30 0:44 ` [PATCH net v3 0/4] net: phy: make PHY driver unbind safe against attach and use Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929174619.727bde40@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=f@lex.la \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maowenan@huawei.com \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.