From: Jakub Kicinski <kuba@kernel.org>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: netdev-bot+sashiko@kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
horms@kernel.org, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com, linux@armlinux.org.uk,
nb@tipi-net.de, jitendra.vegiraju@broadcom.com,
thomas.petazzoni@bootlin.com, alexis.lothore@bootlin.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com, pbrobinson@gmail.com
Subject: Re: [PATCH net-next v2 2/2] net: stmmac: Don't set or get RSS parameters when not supported
Date: Tue, 29 Sep 2026 18:09:28 -0700 [thread overview]
Message-ID: <20260929180928.546f23af@kernel.org> (raw)
In-Reply-To: <71adb267-2dd9-4225-91e5-19848a87eb49@bootlin.com>
On Tue, 29 Sep 2026 10:57:10 +0200 Maxime Chevallier wrote:
> >> @@ -943,6 +949,9 @@ static int stmmac_get_rxfh(struct net_device *dev,
> >> struct stmmac_priv *priv = netdev_priv(dev);
> >> int i;
> >>
> >> + if (!stmmac_rss_is_supported(priv))
> >> + return -EOPNOTSUPP;
> >> +
> >
> > [Severity: Medium]
> > Does this -EOPNOTSUPP break namespace-wide ETHTOOL_MSG_RSS_GET dumps?
>
> This was reported by Nicolai already, and other drivers report -EOPNOTSUPP
> here.
>
> If we address that, I'd say we do that in the RSS ethnl code.
Let's get this in the same series, cause I'm not 100% convinced.
My instinct is that returning 0 size for indir table and key
would be correct and less hairy for the core to handle.
All pieces of RSS are optional so returning 0 size for everything
should be equivalent to having no RSS.
--
pw-bot: cr
next prev parent reply other threads:[~2026-09-30 1:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 14:50 [PATCH net-next v2 0/2] net: stmmac: Report RSS as not supported Maxime Chevallier
2026-09-28 14:50 ` [PATCH net-next v2 1/2] net: stmmac: Introduce a helper to check RSS support Maxime Chevallier
2026-09-29 0:07 ` Joe Damato
2026-09-29 7:10 ` Lorenzo Bianconi
2026-09-28 14:50 ` [PATCH net-next v2 2/2] net: stmmac: Don't set or get RSS parameters when not supported Maxime Chevallier
2026-09-29 0:07 ` Joe Damato
2026-09-29 7:13 ` Lorenzo Bianconi
2026-09-29 8:48 ` netdev-bot+sashiko
2026-09-29 8:57 ` Maxime Chevallier
2026-09-30 1:09 ` Jakub Kicinski [this message]
2026-09-30 7:30 ` Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929180928.546f23af@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=alexis.lothore@bootlin.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jitendra.vegiraju@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=nb@tipi-net.de \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pbrobinson@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.