All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Florian Fainelli" <florian.fainelli@broadcom.com>
Cc: linux-perf-users@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH stable 5.15 1/2] perf tools: Fix a asan issue in parse_events_multi_pmu_add()
Date: Tue, 29 Sep 2026 19:23:11 +0000	[thread overview]
Message-ID: <20260929192312.000C91F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260929191541.264038-2-florian.fainelli@broadcom.com>

> From: Namhyung Kim <namhyung@kernel.org>
> 
> commit 66c9598bd8916c6c1319d0100ac916cac89d4b0e upstream
> 
> In the parse_events_multi_pmu_add() it passes the 'config' variable
> twice to parse_events_term__num() - one for config and another for
> loc_term.  I'm not sure about the second one as it's converted to
> YYLTYPE variable.  Asan reports it like below:
> 
>   In function ‘parse_events_term__num’,
>       inlined from ‘parse_events_multi_pmu_add’ at util/parse-events.c:1602:6:
>   util/parse-events.c:2653:64: error: array subscript ‘YYLTYPE[0]’ is partly outside
>                                       array bounds of ‘char[8]’ [-Werror=array-bounds]
>    2653 |                 .err_term  = loc_term ? loc_term->first_column : 0,
>         |                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
> [ ... ]
> Link: https://lore.kernel.org/r/20230331202949.810326-2-namhyung@kernel.org
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> [florian: Resolve conflict in parse_events_multi_pmu_add() where term
>  initialization is located inside the PMU scan loop in 5.15.y]
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260929191541.264038-1-florian.fainelli@broadcom.com?part=1


  reply	other threads:[~2026-09-29 19:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29 19:15 [PATCH stable 5.15 0/2] perf build warnings fixes Florian Fainelli
2026-09-29 19:15 ` [PATCH stable 5.15 1/2] perf tools: Fix a asan issue in parse_events_multi_pmu_add() Florian Fainelli
2026-09-29 19:23   ` sashiko-bot [this message]
2026-09-29 19:15 ` [PATCH stable 5.15 2/2] perf test bpf: Address error about non-null argument for epoll_pwait 2nd arg Florian Fainelli
2026-09-29 19:20   ` sashiko-bot
2026-10-01 13:52 ` [PATCH stable 5.15 0/2] perf build warnings fixes Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260929192312.000C91F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.