Re: [PATCH net-next v24 01/10] dt-bindings: net: dsa: Document support for Airoha AN8855 DSA Switch

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: unresolved phandles in example break dt_binding_check
--

commit 940a9845cb44d5578faba1549988a5be5ce97b7a
Author: Christian Marangi <ansuelsmth@gmail.com>

dt-bindings: net: dsa: Document support for Airoha AN8855 DSA Switch

This commit documents the device tree bindings for the Airoha AN8855 5-port
Gigabit Switch. It provides an example configuration demonstrating how the
switch ports map to internal PHYs.

> diff --git a/Documentation/devicetree/bindings/net/dsa/airoha,an8855-switch.yaml b/Documentation/devicetree/bindings/net/dsa/airoha,an8855-switch.yaml
> new file mode 100644
> index 0000000000000..5ad9b9e139831
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/dsa/airoha,an8855-switch.yaml

[ ... ]

> +examples:
> +  - |
> +    ethernet-switch {
> +        compatible = "airoha,an8855-switch";
> +
> +        ports {
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +
> +            port@0 {
> +                reg = <0>;
> +                label = "lan1";
> +                phy-mode = "internal";
> +                phy-handle = <&internal_phy1>;

[Severity: Low]
Will this examples block fail dt_binding_check compilation?

The examples block in
Documentation/devicetree/bindings/net/dsa/airoha,an8855-switch.yaml
uses node references like &internal_phy1 through &internal_phy5 for the
phy-handle properties. However, these node labels are never defined anywhere
within the example snippet.

When make dt_binding_check runs, dtc extracts the examples section into
a standalone DTS file and compiles it. Won't these undefined references cause
a fatal reference error during compilation?

> +            };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928194511.41878-1-ansuelsmth@gmail.com?part=1