Re: [PATCH] drm/xe/xe3p: Force non-compressible memory reads to 256B overfetches

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] drm/xe: missing media GT tuning for NONCOMPMEMRD256BOVRFETCHEN
--

commit 0d0918701116e6b353267a1af32ce09421b27bbd
Author: Daniel Charles <daniel.charles@intel.com>

drm/xe/xe3p: Force non-compressible memory reads to 256B overfetches

This commit adds a tuning entry to set bit 14 (NONCOMPMEMRD256BOVRFETCHEN)
of L3SQCREG2 for Xe3p and later platforms to force non-compressible memory
reads to 256B overfetches.

> diff --git a/drivers/gpu/drm/xe/xe_tuning.c b/drivers/gpu/drm/xe/xe_tuning.c
> index bcec40ca2d35f..a9bd3f8969a54 100644
> --- a/drivers/gpu/drm/xe/xe_tuning.c
> +++ b/drivers/gpu/drm/xe/xe_tuning.c

[ ... ]

> @@ -100,6 +100,10 @@ VISIBLE_IF_KUNIT const struct xe_rtp_table_sr gt_tunings = XE_RTP_TABLE_SR(
>  	  XE_RTP_ACTIONS(FIELD_SET(GAMSTLB_CTRL, BANK_HASH_MODE,
>  				   BANK_HASH_4KB_MODE))
>  	},
> +	{ XE_RTP_NAME("Tuning: Force All Non-Compressible Memory Reads to be 256B Overfetches"),
> +	  XE_RTP_RULES(GRAPHICS_VERSION_RANGE(3510, XE_RTP_END_VERSION_UNDEFINED)),
> +	  XE_RTP_ACTIONS(SET(L3SQCREG2, NONCOMPMEMRD256BOVRFETCHEN))
> +	},

[Severity: Medium]
Should this tuning also be applied to the standalone Media GT?

Since this rule uses GRAPHICS_VERSION_RANGE(), it evaluates to false for
standalone Media GTs when checked in xe_rtp_match_graphics_version_range().
Xe3p platforms feature a standalone Media GT with its own L3 cache controlled
by XE2LPM_L3SQCREG2.

Previous overfetch tunings for the same cache (such as
COMPMEMRD256BOVRFETCHEN) provided a companion rule using MEDIA_VERSION_RANGE.

Is there a similar configuration needed here to optimize non-compressible
memory reads for the Media GT L3 cache?

>  );
>  EXPORT_SYMBOL_IF_KUNIT(gt_tunings);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260929200839.843116-1-daniel.charles@intel.com?part=1