Re: [PATCH v3 04/13] iio: adc: ad4134: Serialize single-read operations

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] typo in the new comment describing `sync_lock`
--

commit b5e93b2d37821a8e474f3fdacabd2e3e420e3376
Author: Marcelo Schmitt <marcelo.schmitt@analog.com>

iio: adc: ad4134: Serialize single-read operations

This commit protects single-sample read operations from failing if two or
more of them run concurrently. It serializes the data read operation to
avoid single-sample read requests disrupting each other.

> diff --git a/drivers/iio/adc/ad4134.c b/drivers/iio/adc/ad4134.c
> index 4c8adb8efe4e2..db3cf69401f67 100644
> --- a/drivers/iio/adc/ad4134.c
> +++ b/drivers/iio/adc/ad4134.c
[ ... ]
> @@ -98,6 +100,11 @@ struct ad4134_state {
>  	struct regmap *regmap;
>  	unsigned long sys_clk_hz;
>  	struct gpio_desc *odr_gpio;
> +	/*
> +	 * Synchronize access to members the of device state, and ensure

[Severity: Low]
This isn't a bug, but there is a typo in the comment here. Should
"members the of" be written as "members of the"?

> +	 * atomicity of consecutive register access operations.
> +	 */
> +	struct mutex sync_lock;
>  	int refin_mv;
>  	/*
>  	 * DMA (thus cache coherency maintenance) requires the transfer buffers

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1790719424.git.marcelo.schmitt@analog.com?part=4