From: Michael Roth <michael.roth@amd.com>
To: <qemu-devel@nongnu.org>
Cc: <pbonzini@redhat.com>, <armbru@redhat.com>,
<pankaj.gupta@amd.com>, <xiaoyao.li@intel.com>,
<chao.p.peng@linux.intel.com>, <david@kernel.org>,
<berrange@redhat.com>, Peter Xu <peterx@redhat.com>,
Fabiano Rosas <farosas@suse.de>
Subject: [PATCH v7 03/12] kvm: Provide explicit error for kvm_create_guest_memfd()
Date: Tue, 29 Sep 2026 18:50:09 -0500 [thread overview]
Message-ID: <20260929235109.1398509-4-michael.roth@amd.com> (raw)
In-Reply-To: <20260929235109.1398509-1-michael.roth@amd.com>
From: Peter Xu <peterx@redhat.com>
So that there will be a verbal string returned when kvm not enabled, or
kvm not compiled.
Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Xiaoyao Li <xiaoyao.li@intel.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Michael Roth <michael.roth@amd.com>
Reviewed-by: David Hildenbrand <david@kernel.org>
Signed-off-by: Michael Roth <michael.roth@amd.com>
---
accel/kvm/kvm-all.c | 11 +++++++++++
accel/stubs/kvm-stub.c | 1 +
2 files changed, 12 insertions(+)
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index 120cab1e22..0b1407e4ea 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -4758,6 +4758,17 @@ int kvm_create_guest_memfd(uint64_t size, uint64_t flags, Error **errp)
.flags = flags,
};
+ /*
+ * kvm_create_guest_memfd() can be invoked from generic hostmem code
+ * where KVM might be compiled but not necessarily enabled. Because
+ * of this, check for KVM support explicitly before continuing with
+ * any KVM-specific checks.
+ */
+ if (!kvm_enabled()) {
+ error_setg(errp, "guest-memfd requires KVM accelerator");
+ return -1;
+ }
+
if (!kvm_guest_memfd_supported) {
error_setg(errp, "KVM does not support guest_memfd");
return -1;
diff --git a/accel/stubs/kvm-stub.c b/accel/stubs/kvm-stub.c
index 3d34e3b99d..acbd0785e0 100644
--- a/accel/stubs/kvm-stub.c
+++ b/accel/stubs/kvm-stub.c
@@ -141,6 +141,7 @@ bool kvm_hwpoisoned_mem(void)
int kvm_create_guest_memfd(uint64_t size, uint64_t flags, Error **errp)
{
+ error_setg(errp, "KVM is not enabled");
return -ENOSYS;
}
--
2.43.0
next prev parent reply other threads:[~2026-09-29 23:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 23:50 [PATCH v7 00/12] KVM/hostmem: Support init-shared guest-memfd as VM backends Michael Roth
2026-09-29 23:50 ` [PATCH v7 01/12] kvm: Decouple memory attribute check from kvm_guest_memfd_supported Michael Roth
2026-09-29 23:50 ` [PATCH v7 02/12] kvm: Detect guest-memfd flags supported Michael Roth
2026-09-29 23:50 ` Michael Roth [this message]
2026-09-29 23:50 ` [PATCH v7 04/12] ramblock: Rename guest_memfd to guest_memfd_private Michael Roth
2026-09-29 23:50 ` [PATCH v7 05/12] memory: Rename RAM_GUEST_MEMFD to RAM_GUEST_MEMFD_PRIVATE Michael Roth
2026-09-29 23:50 ` [PATCH v7 06/12] memory: Rename memory_region_has_guest_memfd() to *_private() Michael Roth
2026-09-29 23:50 ` [PATCH v7 07/12] hostmem: Rename guest_memfd to guest_memfd_private Michael Roth
2026-09-29 23:50 ` [PATCH v7 08/12] machine: Rename machine_require_guest_memfd() to *_private() Michael Roth
2026-09-29 23:50 ` [PATCH v7 09/12] memory: Rename memory_region_init_ram_guest_memfd() " Michael Roth
2026-09-29 23:50 ` [PATCH v7 10/12] hostmem: Support fully shared guest memfd to back a VM Michael Roth
2026-09-30 5:13 ` Markus Armbruster
2026-09-30 15:10 ` Peter Xu
2026-09-29 23:50 ` [PATCH v7 11/12] tests/migration-test: Support guest-memfd init shared mem type Michael Roth
2026-09-29 23:50 ` [PATCH v7 12/12] tests/migration-test: Add a precopy test for guest-memfd Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929235109.1398509-4-michael.roth@amd.com \
--to=michael.roth@amd.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=chao.p.peng@linux.intel.com \
--cc=david@kernel.org \
--cc=farosas@suse.de \
--cc=pankaj.gupta@amd.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.