All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Deepanshu Kartikey <kartikey406@gmail.com>
Cc: kees@kernel.org, pavel.hofman@ivitera.com,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	syzbot+e1d0e66badecc32d45eb@syzkaller.appspotmail.com
Subject: Re: [PATCH] usb: gadget: u_audio: reject srate request for unconfigured direction
Date: Tue, 29 Sep 2026 15:23:49 +0200	[thread overview]
Message-ID: <2026092925-licorice-strode-7905@gregkh> (raw)
In-Reply-To: <20260821114854.12218-1-kartikey406@gmail.com>

On Fri, Aug 21, 2026 at 05:18:54PM +0530, Deepanshu Kartikey wrote:
> u_audio_get_playback_srate() unconditionally locks and reads
> uac->p_prm.lock/srate, but g_audio_setup() only initializes
> p_prm.lock when p_chmask is set. On a UAC2 instance configured
> without a playback direction, this results in acquiring a
> never spin_lock_init()'d lock when a GET_CUR sample rate
> request targets playback, triggering a lockdep "trying to
> register non-static key" warning.
> 
> Reject the request with -EOPNOTSUPP when p_chmask is not set,
> before touching prm->lock.
> 
> Fixes: eb3a1ce6f5ed ("usb: gadget: u_audio: Add capture/playback srate getter")
> Reported-by: syzbot+e1d0e66badecc32d45eb@syzkaller.appspotmail.com
> Closes: http://syzkaller.appspot.com/bug?extid=e1d0e66badecc32d45eb
> Signed-off-by: Deepanshu Kartikey <kartikey406@gmail.com>
> ---

How was this tested?

Did you forget a Assisted-by: tag?

thanks,

greg k-h

  parent reply	other threads:[~2026-09-29 13:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21 11:48 [PATCH] usb: gadget: u_audio: reject srate request for unconfigured direction Deepanshu Kartikey
2026-09-12  1:11 ` Deepanshu Kartikey
2026-09-23  3:31 ` Deepanshu Kartikey
2026-09-29 13:23   ` Greg KH
2026-09-29 13:23 ` Greg KH [this message]
2026-09-30  8:18   ` Deepanshu Kartikey
     [not found] <20260821114427.11896-1-kartikey406@gmail.com>
2026-08-21 11:44 ` syzbot
     [not found] <20260821114238.11840-1-kartikey406@gmail.com>
2026-08-21 11:42 ` syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026092925-licorice-strode-7905@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=kartikey406@gmail.com \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pavel.hofman@ivitera.com \
    --cc=syzbot+e1d0e66badecc32d45eb@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.