All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alice Ryhl <aliceryhl@google.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Carlos Llamas <cmllamas@google.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Tamir Duberstein" <tamird@kernel.org>,
	"Alexandre Courbot" <acourbot@nvidia.com>,
	"Onur Özkan" <work@onurozkan.dev>,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
	"Alice Ryhl" <aliceryhl@google.com>
Subject: [PATCH v2 0/3] rust_binder: error line numbers and failed_transaction_log
Date: Wed, 30 Sep 2026 13:56:35 +0000	[thread overview]
Message-ID: <20260930-binder-transaction-log-v2-0-8a15e9b8cae3@google.com> (raw)

When diagnosing Binder issues, it's useful to know what the most recent
failed transactions are, so include a transaction log with this content
matching the C Binder transaction log.

While we're at it, improve the line number information emitted by Rust
Binder using #[track_caller].

Signed-off-by: Alice Ryhl <aliceryhl@google.com>
---
Changes in v2:
- Retry on 0 in next_debug_id() so 0 is never returned on wrap-around.
- Handle debug_id wrap-around in TransactionLog::add using wrapping_sub.
- Link to v1: https://lore.kernel.org/r/20260930-binder-transaction-log-v1-0-3d832fb30388@google.com

---
Alice Ryhl (3):
      rust_binder: never return 0 from next_debug_id
      rust_binder: track caller location in BinderError
      rust_binder: add transaction_log and failed_transaction_log

 drivers/android/binder/context.rs             |   8 +-
 drivers/android/binder/error.rs               |  39 +++++
 drivers/android/binder/process.rs             |   5 +-
 drivers/android/binder/rust_binder_internal.h |   1 +
 drivers/android/binder/rust_binder_main.rs    |  31 +++-
 drivers/android/binder/rust_binderfs.c        |  19 +++
 drivers/android/binder/thread.rs              |  12 +-
 drivers/android/binder/transaction.rs         | 197 +++++++++++++++++++++++++-
 8 files changed, 302 insertions(+), 10 deletions(-)
---
base-commit: 72d3fcf802c45d00b300f25b848a93c3a2bd7c7e
change-id: 20260930-binder-transaction-log-94989f47b142

Best regards,
-- 
Alice Ryhl <aliceryhl@google.com>


             reply	other threads:[~2026-09-30 13:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-30 13:56 Alice Ryhl [this message]
2026-09-30 13:56 ` [PATCH v2 1/3] rust_binder: never return 0 from next_debug_id Alice Ryhl
2026-09-30 13:56 ` [PATCH v2 2/3] rust_binder: track caller location in BinderError Alice Ryhl
2026-09-30 13:56 ` [PATCH v2 3/3] rust_binder: add transaction_log and failed_transaction_log Alice Ryhl
2026-10-01 12:34   ` Greg Kroah-Hartman
2026-10-01 14:11     ` [PATCH v2 3/3 rebased] " Alice Ryhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260930-binder-transaction-log-v2-0-8a15e9b8cae3@google.com \
    --to=aliceryhl@google.com \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=cmllamas@google.com \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tamird@kernel.org \
    --cc=tmgross@umich.edu \
    --cc=work@onurozkan.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.