From: Hui Peng <benquike@gmail.com>
To: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"John Ogness" <john.ogness@linutronix.de>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Hui Peng <benquike@gmail.com>
Subject: [PATCH v5 0/3] serial: fix IRQ chain race, baud fallback, and uartclk overflow
Date: Wed, 30 Sep 2026 04:12:13 +0000 [thread overview]
Message-ID: <20260930041216.155911-1-benquike@gmail.com> (raw)
This series fixes three bugs in the 8250 and serial core drivers:
1. Hold hash_mutex across IRQ chain lookup, linking, and error-path
unlinking in serial_link_irq_chain() to prevent a use-after-free race
with concurrent serial_unlink_irq_chain().
2. Allow a third loop iteration (try < 3) in uart_get_baud_rate() so that
when both the requested and old baud rates are out of range and try == 1
clips the rate into termios, the clipped baud rate is evaluated and
returned on try == 2 instead of returning 0 and causing a divide-by-zero
in uart_get_divisor().
3. Reject baud_base > UINT_MAX / 16 in uart_set_info() alongside the
uartclk == 0 check so that multiplying baud_base by 16 cannot wrap
around in 32-bit unsigned arithmetic to a small non-zero uartclk.
Changes in v5:
- Rebased cleanly and tested for applicability against tip of upstream
mainline commit 62f4c998b297 ("Merge tag 'parisc-for-7.3-rc5' of
git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux").
- Dynamically verified all 3 issues in QEMU KVM with CONFIG_KASAN=y against
unfixed vs fixed kernels, adding explicit test methods to commit bodies.
- Patch 1/3: Updated diff to align with upstream guard(mutex) refactoring.
- Patch 2/3: Trimmed kernel stack trace in commit message to 4 key lines,
as suggested by Andy Shevchenko.
- Patch 3/3: Collected Reviewed-by from Ilpo Järvinen.
- Re-sending full series as a fresh standalone thread per Andy Shevchenko's
feedback.
Changes in v4:
- Patch 3/3: Check new_info->baud_base > UINT_MAX / 16 before
multiplying by 16, as suggested by Ilpo Järvinen.
Changes in v3:
- Patch 2/3: Collect Reviewed-by from Ilpo Järvinen.
- Patch 3/3: Add missing #include <linux/limits.h> for UINT_MAX and move
the new_info->baud_base > UINT_MAX / 16 check to the uartclk == 0 check,
as suggested by Ilpo Järvinen.
Changes in v2:
- Split the 8250_core.c and serial_core.c fixes into a 3-patch series,
add Cc: stable@vger.kernel.org, and document how each patch was tested in
QEMU, as requested by Greg Kroah-Hartman and John Ogness.
Hui Peng (3):
serial: 8250: hold hash_mutex across IRQ chain linking in
serial_link_irq_chain()
serial: core: allow third iteration in uart_get_baud_rate() fallback
serial: core: reject baud_base values that overflow port->uartclk in
uart_set_info()
drivers/tty/serial/8250/8250_core.c | 10 ++++------
drivers/tty/serial/serial_core.c | 5 +++--
2 files changed, 7 insertions(+), 8 deletions(-)
next reply other threads:[~2026-09-30 4:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 4:12 Hui Peng [this message]
2026-09-30 4:12 ` [PATCH v5 1/3] serial: 8250: hold hash_mutex across IRQ chain linking in serial_link_irq_chain() Hui Peng
2026-09-30 4:19 ` sashiko-bot
2026-09-30 10:06 ` Ilpo Järvinen
2026-09-30 4:12 ` [PATCH v5 2/3] serial: core: allow third iteration in uart_get_baud_rate() fallback Hui Peng
2026-09-30 4:21 ` sashiko-bot
2026-09-30 4:12 ` [PATCH v5 3/3] serial: core: reject baud_base values that overflow port->uartclk in uart_set_info() Hui Peng
2026-09-30 4:19 ` sashiko-bot
2026-09-30 6:29 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930041216.155911-1-benquike@gmail.com \
--to=benquike@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.