From: sashiko-bot@kernel.org
To: "Nikolay Plastinin" <plaztininikolai@gmail.com>
Cc: linux-leds@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH v2 1/2] leds: triggers: Add led_trigger_walk_leds()
Date: Wed, 30 Sep 2026 06:58:58 +0000 [thread overview]
Message-ID: <20260930065858.BE0B11F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260930-leds-input-events-brightness-v2-1-3948d3cddd83@gmail.com>
> From: Nikolay Plastinin <plaztininikolai@gmail.com>
>
> led_trigger_event() sets one brightness for all LEDs using a trigger.
> A trigger which restores a different brightness per LED, such as the
> input-events trigger turning keyboard backlights back on at the level
> the user picked, needs to walk the trigger's LEDs itself. That means
> using trig->led_cdevs and led_cdev->trig_list outside the LED core.
>
> Add led_trigger_walk_leds(), which calls a function for each LED
> using the trigger under rcu_read_lock(), the same way led_trigger_event()
> does, so that such triggers do not have to walk the list themselves.
>
> Assisted-by: LLM
> Signed-off-by: Nikolay Plastinin <plaztininikolai@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260930-leds-input-events-brightness-v2-0-3948d3cddd83@gmail.com?part=1
next prev parent reply other threads:[~2026-09-30 6:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 6:54 [PATCH v2 0/2] leds: trigger: input-events: Restore previous brightness on input Nikolay Plastinin
2026-09-30 6:54 ` Nikolay Plastinin via B4 Relay
2026-09-30 6:54 ` [PATCH v2 1/2] leds: triggers: Add led_trigger_walk_leds() Nikolay Plastinin
2026-09-30 6:54 ` Nikolay Plastinin via B4 Relay
2026-09-30 6:58 ` sashiko-bot [this message]
2026-09-30 6:54 ` [PATCH v2 2/2] leds: trigger: input-events: Restore previous brightness on input Nikolay Plastinin
2026-09-30 6:54 ` Nikolay Plastinin via B4 Relay
2026-09-30 7:02 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930065858.BE0B11F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=plaztininikolai@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.