From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 436043148CF for ; Wed, 30 Sep 2026 07:31:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790753461; cv=none; b=VjIy9TWpktUxmmJ1ZGHgaHTIZyuPvNIeBn2sCUCYG3nOUdT9A9/xSTjvu2UaBSuLK71VrCuMMNgXSOlSGvl1PS62/5QL6bGBeXgiyflLgH4cHAUtQUlHcQrZBIbe+t12a8pgqnabGOwolrDMu15wwWY+eiPICeq6cr0R2TQsLP8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790753461; c=relaxed/simple; bh=eYdHJeanoytOvHxOiexMx85+NrozDctGZegzcIuMN5s=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=tEjHuGIduLf7q2dg6AGG8F6cj/p3pjf1F6/fBF5z+Z4N6la3FvOB7he+8jR6HFn7YTlMm6w5iSjN0OmhBtakIRaxNYzuYBuPXGc52StXecNHPnnTp5llpIICw4/tx0yPJhMsf5Sz653LNvMh8MIPz63NZNB4DpplgYpjVxTIhr8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VGT5vV8c; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VGT5vV8c" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8373D1F000FF; Wed, 30 Sep 2026 07:30:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790753460; bh=X4MFlg9iQNr1WSjE1OVvLSYFm1fkVX5AH3CfVM/UAqk=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=VGT5vV8cjjlSBMAYRLHsxdNPmyubH31LxdWPEXg36I3iCjXOR2MOyG4oPgH/bCRxW m0JVPgqBnWW1Ae0U7ElEeTW5J0++GclTkHeE0w2k6Kf2TT2aLpanyAjCI5DCdq6AqR QhxcjJCBRdURTmGGhMzfnUs2iTtHSSc0DHzshEkIR0C+7sM6yufyS8bXwiMA6+iTMF YRP1fML6YmXl32O4qQ0WUPO5jIEBS3bIbAYgKEGAD931IdxvqMiHx3uF6gTkwuQLJI JeucUwx/04Lka6S19NnvQdWqJarQ9XGmg5U+aer+TXlj3uBW8MSKpAghWhCBuiFXpv AlF9K6dARiF7g== From: sashiko-bot@kernel.org Subject: Re: [PATCH v12 3/3] phy: airoha: Add support for Airoha AN7581 USB PHY Reply-To: sashiko-reviews@lists.linux.dev To: "Christian Marangi" Cc: robh@kernel.org, conor+dt@kernel.org, olteanv@gmail.com, vkoul@kernel.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org In-Reply-To: <20260930071826.48811-4-ansuelsmth@gmail.com> References: <20260930071826.48811-1-ansuelsmth@gmail.com> <20260930071826.48811-4-ansuelsmth@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 30 Sep 2026 07:30:59 +0000 Message-Id: <20260930073059.8373D1F000FF@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 3 potential issue(= s) to consider: - [High] phy: airoha: Missing phy_init() and phy_power_on() for serdes_phy - [Medium] phy: airoha: regmap_set_bits() fails to clear multi-bit field - [Low] phy: airoha: Silent truncation of dynamic srctrl calibration value -- commit 4a0c27f02fe4864e660c9a34276ee9067ec33998 Author: Christian Marangi phy: airoha: Add support for Airoha AN7581 USB PHY Add support for Airoha AN7581 USB PHY driver. AN7581 supports up to 2 USB port with USB 2.0 mode always supported and USB 3.0 mode available only if the Serdes port is correctly configured for USB 3.0. > diff --git a/drivers/phy/airoha/phy-an7581-usb.c b/drivers/phy/airoha/phy= -an7581-usb.c > new file mode 100644 > index 0000000000000..92c5e5c2fbf3b > --- /dev/null > +++ b/drivers/phy/airoha/phy-an7581-usb.c [ ... ] > +static void an7581_usb_phy_u2_slew_rate_calibration(struct an7581_usb_ph= y_priv *priv) > +{ > + u32 fm_out =3D 0; > + u32 srctrl; [ ... ] > + /* Frequency was not detected, use default SR calibration value */ > + if (!fm_out) { > + srctrl =3D AIROHA_USB_PHY_DEFAULT_SR_CALIBRATION; > + dev_err(priv->dev, "Frequency not detected, using default SR calibrati= on.\n"); > + } else { > + /* (1024 / FM_OUT) * REF_CK * U2_SR_COEF (round to the nearest digits)= */ > + srctrl =3D AIROHA_USB_PHY_REF_CK * AIROHA_USB_PHY_U2_SR_COEF; > + srctrl =3D (srctrl * AIROHA_USB_PHY_U2_FM_DET_CYCLE_CNT) / fm_out; > + srctrl =3D DIV_ROUND_CLOSEST(srctrl, AIROHA_USB_PHY_U2_SR_COEF_DIVISOR= ); > + dev_dbg(priv->dev, "SR calibration applied: %x\n", srctrl); > + } > + > + regmap_update_bits(priv->regmap, AIROHA_USB_PHY_USBPHYACR5, > + AIROHA_USB_PHY_USB20_HSTX_SRCTRL, > + FIELD_PREP(AIROHA_USB_PHY_USB20_HSTX_SRCTRL, srctrl)); [Severity: Low] Does this dynamically calculated srctrl value need bounds checking? If a glitchy or slow clock results in a small non-zero fm_out, srctrl might exceed the 3-bit maximum (7) defined by AIROHA_USB_PHY_USB20_HSTX_SRCTRL. Since it is passed to FIELD_PREP() without clamping, the upper bits will be silently truncated, applying a potentially incorrect slew rate calibration rather than a safe default. [ ... ] > +static void an7581_usb_phy_u3_init(struct an7581_usb_phy_priv *priv) > +{ > + regmap_update_bits(priv->regmap, AIROHA_USB_PHY_U3_PHYA_REG8, > + AIROHA_USB_PHY_SSUSB_CDR_RST_DLY, > + AIROHA_USB_PHY_SSUSB_CDR_RST_DLY_32); > + > + regmap_update_bits(priv->regmap, AIROHA_USB_PHY_U3_PHYA_REG6, > + AIROHA_USB_PHY_SSUSB_CDR_RESERVE, > + FIELD_PREP(AIROHA_USB_PHY_SSUSB_CDR_RESERVE, 0xe)); > + > + regmap_update_bits(priv->regmap, AIROHA_USB_PHY_U3_PHYA_REG0, > + AIROHA_USB_PHY_SSUSB_BG_DIV, > + AIROHA_USB_PHY_SSUSB_BG_DIV_4); > + > + regmap_set_bits(priv->regmap, AIROHA_USB_PHY_U3_PHYA_REG1, > + FIELD_PREP(AIROHA_USB_PHY_SSUSB_XTAL_TOP_RESERVE, 0x600)); [Severity: Medium] Should this be using regmap_update_bits() instead of regmap_set_bits()? AIROHA_USB_PHY_SSUSB_XTAL_TOP_RESERVE is a 16-bit mask (GENMASK(25, 10)). Using regmap_set_bits() with FIELD_PREP() performs a simple bitwise OR. This will set the bits corresponding to 1s in 0x600, but it will fail to clear any other bits across the rest of the 16-bit mask if they happen to be set by default. This could leave stale bits in the register. > + > + regmap_update_bits(priv->regmap, AIROHA_USB_PHY_U3_PHYA_DA_REG19, > + AIROHA_USB_PHY_SSUSB_PLL_SSC_DELTA1_U3, > + FIELD_PREP(AIROHA_USB_PHY_SSUSB_PLL_SSC_DELTA1_U3, 0x43)); > +} > + > +static int an7581_usb_phy_init(struct phy *phy) > +{ > + struct an7581_usb_phy_instance *instance =3D phy_get_drvdata(phy); > + struct an7581_usb_phy_priv *priv =3D dev_get_drvdata(phy->dev.parent); > + int ret; > + > + switch (instance->type) { > + case PHY_TYPE_USB2: > + an7581_usb_phy_u2_init(priv); > + break; > + case PHY_TYPE_USB3: > + ret =3D phy_set_mode(priv->serdes_phy, PHY_MODE_USB_DEVICE_SS); > + if (ret) > + return ret; > + > + an7581_usb_phy_u3_init(priv); [Severity: High] Is a call to phy_init(priv->serdes_phy) missing here? The serdes_phy mode is set, but the mandatory phy_init() lifecycle call is omitted. The downstream controller (e.g., xHCI or DWC3) requests this wrapper PHY and invokes phy_init(). The wrapper receives this call via an7581_usb_phy_init() but completely fails to propagate it to its consumed priv->serdes_phy, leaving the hardware unconfigured and breaking USB 3.0 functionality. > + break; > + default: > + return -EINVAL; > + } > + > + return 0; > +} [ ... ] > +static int an7581_usb_phy_power_on(struct phy *phy) > +{ > + struct an7581_usb_phy_instance *instance =3D phy_get_drvdata(phy); > + struct an7581_usb_phy_priv *priv =3D dev_get_drvdata(phy->dev.parent); > + > + switch (instance->type) { > + case PHY_TYPE_USB2: > + an7581_usb_phy_u2_power_on(priv); > + break; > + case PHY_TYPE_USB3: > + an7581_usb_phy_u3_power_on(priv); > + break; [Severity: High] Does this function also need to call phy_power_on(priv->serdes_phy)? The local USB3 registers are powered on via an7581_usb_phy_u3_power_on(), but the driver fails to propagate the power_on call to the underlying priv->serdes_phy. The PHY subsystem API strictly requires a consumer of a PHY to call phy_init() and phy_power_on() before the PHY can be functional. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260930071826.4881= 1-1-ansuelsmth@gmail.com?part=3D3 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F749CA5FB1 for ; Wed, 30 Sep 2026 07:31:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m2iJby35RUcvEpk4mVz8yKT7fFH5r/Tya7E86fsLHTY=; b=Oee/sAsnWxE8VX itGUeCaaWUe+k2rgVuUtMaVTYo9SzIXVqcvVbmjjn8xKMN1m/OqbzFD/XYWPW9tevmBUbcpHN2UJt /NOAaCUoBN+8sm7mom3IqpvuBxUmzK9Ul1a1IjMwLNf9kN1OfZO/ngTt2i0K9agX4SH2wVE63dfYj x5XtA9VLrqIg5/RfkvT5nOc/w8rRo56b71kcZagSEaGtcjDAbPX4EVpn+1Jh2IaFeAKThGNHVw1V0 BV93Eri93ktmuwjpXLN7nby5GrkdjO2qVCef18sCIUn/i/2wXYnJF9t5M88PysV/aORAjDXrZM5gF 0VBEgf4fsr/ipwLrGung==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xBomL-00000005HFf-2rpY; Wed, 30 Sep 2026 07:31:01 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xBomK-00000005HFV-2yOl for linux-phy@lists.infradead.org; Wed, 30 Sep 2026 07:31:00 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 1BAF443C73; Wed, 30 Sep 2026 07:31:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8373D1F000FF; Wed, 30 Sep 2026 07:30:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790753460; bh=X4MFlg9iQNr1WSjE1OVvLSYFm1fkVX5AH3CfVM/UAqk=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=VGT5vV8cjjlSBMAYRLHsxdNPmyubH31LxdWPEXg36I3iCjXOR2MOyG4oPgH/bCRxW m0JVPgqBnWW1Ae0U7ElEeTW5J0++GclTkHeE0w2k6Kf2TT2aLpanyAjCI5DCdq6AqR QhxcjJCBRdURTmGGhMzfnUs2iTtHSSc0DHzshEkIR0C+7sM6yufyS8bXwiMA6+iTMF YRP1fML6YmXl32O4qQ0WUPO5jIEBS3bIbAYgKEGAD931IdxvqMiHx3uF6gTkwuQLJI JeucUwx/04Lka6S19NnvQdWqJarQ9XGmg5U+aer+TXlj3uBW8MSKpAghWhCBuiFXpv AlF9K6dARiF7g== From: sashiko-bot@kernel.org Subject: Re: [PATCH v12 3/3] phy: airoha: Add support for Airoha AN7581 USB PHY To: "Christian Marangi" Cc: robh@kernel.org, conor+dt@kernel.org, olteanv@gmail.com, vkoul@kernel.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org In-Reply-To: <20260930071826.48811-4-ansuelsmth@gmail.com> References: <20260930071826.48811-1-ansuelsmth@gmail.com> <20260930071826.48811-4-ansuelsmth@gmail.com> Date: Wed, 30 Sep 2026 07:30:59 +0000 Message-Id: <20260930073059.8373D1F000FF@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MyBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIHBoeTogYWlyb2hhOiBN aXNzaW5nIHBoeV9pbml0KCkgYW5kIHBoeV9wb3dlcl9vbigpIGZvciBzZXJkZXNfcGh5Ci0gW01l ZGl1bV0gcGh5OiBhaXJvaGE6IHJlZ21hcF9zZXRfYml0cygpIGZhaWxzIHRvIGNsZWFyIG11bHRp LWJpdCBmaWVsZAotIFtMb3ddIHBoeTogYWlyb2hhOiBTaWxlbnQgdHJ1bmNhdGlvbiBvZiBkeW5h bWljIHNyY3RybCBjYWxpYnJhdGlvbiB2YWx1ZQotLQoKY29tbWl0IDRhMGMyN2YwMmZlNDg2NGU2 NjBjOWEzNDI3NmVlOTA2N2VjMzM5OTgKQXV0aG9yOiBDaHJpc3RpYW4gTWFyYW5naSA8YW5zdWVs c210aEBnbWFpbC5jb20+CgpwaHk6IGFpcm9oYTogQWRkIHN1cHBvcnQgZm9yIEFpcm9oYSBBTjc1 ODEgVVNCIFBIWQoKQWRkIHN1cHBvcnQgZm9yIEFpcm9oYSBBTjc1ODEgVVNCIFBIWSBkcml2ZXIu IEFONzU4MSBzdXBwb3J0cyB1cCB0byAyClVTQiBwb3J0IHdpdGggVVNCIDIuMCBtb2RlIGFsd2F5 cyBzdXBwb3J0ZWQgYW5kIFVTQiAzLjAgbW9kZSBhdmFpbGFibGUKb25seSBpZiB0aGUgU2VyZGVz IHBvcnQgaXMgY29ycmVjdGx5IGNvbmZpZ3VyZWQgZm9yIFVTQiAzLjAuCgo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL3BoeS9haXJvaGEvcGh5LWFuNzU4MS11c2IuYyBiL2RyaXZlcnMvcGh5L2Fpcm9o YS9waHktYW43NTgxLXVzYi5jCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAw MDAwMDAwLi45MmM1ZTVjMmZiZjNiCj4gLS0tIC9kZXYvbnVsbAo+ICsrKyBiL2RyaXZlcnMvcGh5 L2Fpcm9oYS9waHktYW43NTgxLXVzYi5jCgpbIC4uLiBdCgo+ICtzdGF0aWMgdm9pZCBhbjc1ODFf dXNiX3BoeV91Ml9zbGV3X3JhdGVfY2FsaWJyYXRpb24oc3RydWN0IGFuNzU4MV91c2JfcGh5X3By aXYgKnByaXYpCj4gK3sKPiArCXUzMiBmbV9vdXQgPSAwOwo+ICsJdTMyIHNyY3RybDsKClsgLi4u IF0KCj4gKwkvKiBGcmVxdWVuY3kgd2FzIG5vdCBkZXRlY3RlZCwgdXNlIGRlZmF1bHQgU1IgY2Fs aWJyYXRpb24gdmFsdWUgKi8KPiArCWlmICghZm1fb3V0KSB7Cj4gKwkJc3JjdHJsID0gQUlST0hB X1VTQl9QSFlfREVGQVVMVF9TUl9DQUxJQlJBVElPTjsKPiArCQlkZXZfZXJyKHByaXYtPmRldiwg IkZyZXF1ZW5jeSBub3QgZGV0ZWN0ZWQsIHVzaW5nIGRlZmF1bHQgU1IgY2FsaWJyYXRpb24uXG4i KTsKPiArCX0gZWxzZSB7Cj4gKwkJLyogKDEwMjQgLyBGTV9PVVQpICogUkVGX0NLICogVTJfU1Jf Q09FRiAocm91bmQgdG8gdGhlIG5lYXJlc3QgZGlnaXRzKSAqLwo+ICsJCXNyY3RybCA9IEFJUk9I QV9VU0JfUEhZX1JFRl9DSyAqIEFJUk9IQV9VU0JfUEhZX1UyX1NSX0NPRUY7Cj4gKwkJc3JjdHJs ID0gKHNyY3RybCAqIEFJUk9IQV9VU0JfUEhZX1UyX0ZNX0RFVF9DWUNMRV9DTlQpIC8gZm1fb3V0 Owo+ICsJCXNyY3RybCA9IERJVl9ST1VORF9DTE9TRVNUKHNyY3RybCwgQUlST0hBX1VTQl9QSFlf VTJfU1JfQ09FRl9ESVZJU09SKTsKPiArCQlkZXZfZGJnKHByaXYtPmRldiwgIlNSIGNhbGlicmF0 aW9uIGFwcGxpZWQ6ICV4XG4iLCBzcmN0cmwpOwo+ICsJfQo+ICsKPiArCXJlZ21hcF91cGRhdGVf Yml0cyhwcml2LT5yZWdtYXAsIEFJUk9IQV9VU0JfUEhZX1VTQlBIWUFDUjUsCj4gKwkJCSAgIEFJ Uk9IQV9VU0JfUEhZX1VTQjIwX0hTVFhfU1JDVFJMLAo+ICsJCQkgICBGSUVMRF9QUkVQKEFJUk9I QV9VU0JfUEhZX1VTQjIwX0hTVFhfU1JDVFJMLCBzcmN0cmwpKTsKCltTZXZlcml0eTogTG93XQpE b2VzIHRoaXMgZHluYW1pY2FsbHkgY2FsY3VsYXRlZCBzcmN0cmwgdmFsdWUgbmVlZCBib3VuZHMg Y2hlY2tpbmc/CgpJZiBhIGdsaXRjaHkgb3Igc2xvdyBjbG9jayByZXN1bHRzIGluIGEgc21hbGwg bm9uLXplcm8gZm1fb3V0LCBzcmN0cmwKbWlnaHQgZXhjZWVkIHRoZSAzLWJpdCBtYXhpbXVtICg3 KSBkZWZpbmVkIGJ5CkFJUk9IQV9VU0JfUEhZX1VTQjIwX0hTVFhfU1JDVFJMLiBTaW5jZSBpdCBp cyBwYXNzZWQgdG8gRklFTERfUFJFUCgpCndpdGhvdXQgY2xhbXBpbmcsIHRoZSB1cHBlciBiaXRz IHdpbGwgYmUgc2lsZW50bHkgdHJ1bmNhdGVkLCBhcHBseWluZwphIHBvdGVudGlhbGx5IGluY29y cmVjdCBzbGV3IHJhdGUgY2FsaWJyYXRpb24gcmF0aGVyIHRoYW4gYSBzYWZlIGRlZmF1bHQuCgpb IC4uLiBdCgo+ICtzdGF0aWMgdm9pZCBhbjc1ODFfdXNiX3BoeV91M19pbml0KHN0cnVjdCBhbjc1 ODFfdXNiX3BoeV9wcml2ICpwcml2KQo+ICt7Cj4gKwlyZWdtYXBfdXBkYXRlX2JpdHMocHJpdi0+ cmVnbWFwLCBBSVJPSEFfVVNCX1BIWV9VM19QSFlBX1JFRzgsCj4gKwkJCSAgIEFJUk9IQV9VU0Jf UEhZX1NTVVNCX0NEUl9SU1RfRExZLAo+ICsJCQkgICBBSVJPSEFfVVNCX1BIWV9TU1VTQl9DRFJf UlNUX0RMWV8zMik7Cj4gKwo+ICsJcmVnbWFwX3VwZGF0ZV9iaXRzKHByaXYtPnJlZ21hcCwgQUlS T0hBX1VTQl9QSFlfVTNfUEhZQV9SRUc2LAo+ICsJCQkgICBBSVJPSEFfVVNCX1BIWV9TU1VTQl9D RFJfUkVTRVJWRSwKPiArCQkJICAgRklFTERfUFJFUChBSVJPSEFfVVNCX1BIWV9TU1VTQl9DRFJf UkVTRVJWRSwgMHhlKSk7Cj4gKwo+ICsJcmVnbWFwX3VwZGF0ZV9iaXRzKHByaXYtPnJlZ21hcCwg QUlST0hBX1VTQl9QSFlfVTNfUEhZQV9SRUcwLAo+ICsJCQkgICBBSVJPSEFfVVNCX1BIWV9TU1VT Ql9CR19ESVYsCj4gKwkJCSAgIEFJUk9IQV9VU0JfUEhZX1NTVVNCX0JHX0RJVl80KTsKPiArCj4g KwlyZWdtYXBfc2V0X2JpdHMocHJpdi0+cmVnbWFwLCBBSVJPSEFfVVNCX1BIWV9VM19QSFlBX1JF RzEsCj4gKwkJCUZJRUxEX1BSRVAoQUlST0hBX1VTQl9QSFlfU1NVU0JfWFRBTF9UT1BfUkVTRVJW RSwgMHg2MDApKTsKCltTZXZlcml0eTogTWVkaXVtXQpTaG91bGQgdGhpcyBiZSB1c2luZyByZWdt YXBfdXBkYXRlX2JpdHMoKSBpbnN0ZWFkIG9mIHJlZ21hcF9zZXRfYml0cygpPwoKQUlST0hBX1VT Ql9QSFlfU1NVU0JfWFRBTF9UT1BfUkVTRVJWRSBpcyBhIDE2LWJpdCBtYXNrIChHRU5NQVNLKDI1 LCAxMCkpLgpVc2luZyByZWdtYXBfc2V0X2JpdHMoKSB3aXRoIEZJRUxEX1BSRVAoKSBwZXJmb3Jt cyBhIHNpbXBsZSBiaXR3aXNlIE9SLgpUaGlzIHdpbGwgc2V0IHRoZSBiaXRzIGNvcnJlc3BvbmRp bmcgdG8gMXMgaW4gMHg2MDAsIGJ1dCBpdCB3aWxsIGZhaWwgdG8KY2xlYXIgYW55IG90aGVyIGJp dHMgYWNyb3NzIHRoZSByZXN0IG9mIHRoZSAxNi1iaXQgbWFzayBpZiB0aGV5IGhhcHBlbgp0byBi ZSBzZXQgYnkgZGVmYXVsdC4gVGhpcyBjb3VsZCBsZWF2ZSBzdGFsZSBiaXRzIGluIHRoZSByZWdp c3Rlci4KCj4gKwo+ICsJcmVnbWFwX3VwZGF0ZV9iaXRzKHByaXYtPnJlZ21hcCwgQUlST0hBX1VT Ql9QSFlfVTNfUEhZQV9EQV9SRUcxOSwKPiArCQkJICAgQUlST0hBX1VTQl9QSFlfU1NVU0JfUExM X1NTQ19ERUxUQTFfVTMsCj4gKwkJCSAgIEZJRUxEX1BSRVAoQUlST0hBX1VTQl9QSFlfU1NVU0Jf UExMX1NTQ19ERUxUQTFfVTMsIDB4NDMpKTsKPiArfQo+ICsKPiArc3RhdGljIGludCBhbjc1ODFf dXNiX3BoeV9pbml0KHN0cnVjdCBwaHkgKnBoeSkKPiArewo+ICsJc3RydWN0IGFuNzU4MV91c2Jf cGh5X2luc3RhbmNlICppbnN0YW5jZSA9IHBoeV9nZXRfZHJ2ZGF0YShwaHkpOwo+ICsJc3RydWN0 IGFuNzU4MV91c2JfcGh5X3ByaXYgKnByaXYgPSBkZXZfZ2V0X2RydmRhdGEocGh5LT5kZXYucGFy ZW50KTsKPiArCWludCByZXQ7Cj4gKwo+ICsJc3dpdGNoIChpbnN0YW5jZS0+dHlwZSkgewo+ICsJ Y2FzZSBQSFlfVFlQRV9VU0IyOgo+ICsJCWFuNzU4MV91c2JfcGh5X3UyX2luaXQocHJpdik7Cj4g KwkJYnJlYWs7Cj4gKwljYXNlIFBIWV9UWVBFX1VTQjM6Cj4gKwkJcmV0ID0gcGh5X3NldF9tb2Rl KHByaXYtPnNlcmRlc19waHksIFBIWV9NT0RFX1VTQl9ERVZJQ0VfU1MpOwo+ICsJCWlmIChyZXQp Cj4gKwkJCXJldHVybiByZXQ7Cj4gKwo+ICsJCWFuNzU4MV91c2JfcGh5X3UzX2luaXQocHJpdik7 CgpbU2V2ZXJpdHk6IEhpZ2hdCklzIGEgY2FsbCB0byBwaHlfaW5pdChwcml2LT5zZXJkZXNfcGh5 KSBtaXNzaW5nIGhlcmU/CgpUaGUgc2VyZGVzX3BoeSBtb2RlIGlzIHNldCwgYnV0IHRoZSBtYW5k YXRvcnkgcGh5X2luaXQoKSBsaWZlY3ljbGUgY2FsbAppcyBvbWl0dGVkLiBUaGUgZG93bnN0cmVh bSBjb250cm9sbGVyIChlLmcuLCB4SENJIG9yIERXQzMpIHJlcXVlc3RzIHRoaXMKd3JhcHBlciBQ SFkgYW5kIGludm9rZXMgcGh5X2luaXQoKS4gVGhlIHdyYXBwZXIgcmVjZWl2ZXMgdGhpcyBjYWxs IHZpYQphbjc1ODFfdXNiX3BoeV9pbml0KCkgYnV0IGNvbXBsZXRlbHkgZmFpbHMgdG8gcHJvcGFn YXRlIGl0IHRvIGl0cyBjb25zdW1lZApwcml2LT5zZXJkZXNfcGh5LCBsZWF2aW5nIHRoZSBoYXJk d2FyZSB1bmNvbmZpZ3VyZWQgYW5kIGJyZWFraW5nIFVTQiAzLjAKZnVuY3Rpb25hbGl0eS4KCj4g KwkJYnJlYWs7Cj4gKwlkZWZhdWx0Ogo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsJfQo+ICsKPiAr CXJldHVybiAwOwo+ICt9CgpbIC4uLiBdCgo+ICtzdGF0aWMgaW50IGFuNzU4MV91c2JfcGh5X3Bv d2VyX29uKHN0cnVjdCBwaHkgKnBoeSkKPiArewo+ICsJc3RydWN0IGFuNzU4MV91c2JfcGh5X2lu c3RhbmNlICppbnN0YW5jZSA9IHBoeV9nZXRfZHJ2ZGF0YShwaHkpOwo+ICsJc3RydWN0IGFuNzU4 MV91c2JfcGh5X3ByaXYgKnByaXYgPSBkZXZfZ2V0X2RydmRhdGEocGh5LT5kZXYucGFyZW50KTsK PiArCj4gKwlzd2l0Y2ggKGluc3RhbmNlLT50eXBlKSB7Cj4gKwljYXNlIFBIWV9UWVBFX1VTQjI6 Cj4gKwkJYW43NTgxX3VzYl9waHlfdTJfcG93ZXJfb24ocHJpdik7Cj4gKwkJYnJlYWs7Cj4gKwlj YXNlIFBIWV9UWVBFX1VTQjM6Cj4gKwkJYW43NTgxX3VzYl9waHlfdTNfcG93ZXJfb24ocHJpdik7 Cj4gKwkJYnJlYWs7CgpbU2V2ZXJpdHk6IEhpZ2hdCkRvZXMgdGhpcyBmdW5jdGlvbiBhbHNvIG5l ZWQgdG8gY2FsbCBwaHlfcG93ZXJfb24ocHJpdi0+c2VyZGVzX3BoeSk/CgpUaGUgbG9jYWwgVVNC MyByZWdpc3RlcnMgYXJlIHBvd2VyZWQgb24gdmlhIGFuNzU4MV91c2JfcGh5X3UzX3Bvd2VyX29u KCksCmJ1dCB0aGUgZHJpdmVyIGZhaWxzIHRvIHByb3BhZ2F0ZSB0aGUgcG93ZXJfb24gY2FsbCB0 byB0aGUgdW5kZXJseWluZwpwcml2LT5zZXJkZXNfcGh5LiBUaGUgUEhZIHN1YnN5c3RlbSBBUEkg c3RyaWN0bHkgcmVxdWlyZXMgYSBjb25zdW1lciBvZiBhClBIWSB0byBjYWxsIHBoeV9pbml0KCkg YW5kIHBoeV9wb3dlcl9vbigpIGJlZm9yZSB0aGUgUEhZIGNhbiBiZSBmdW5jdGlvbmFsLgoKLS0g ClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2 MDkzMDA3MTgyNi40ODgxMS0xLWFuc3VlbHNtdGhAZ21haWwuY29tP3BhcnQ9MwoKLS0gCmxpbnV4 LXBoeSBtYWlsaW5nIGxpc3QKbGludXgtcGh5QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cHM6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcGh5Cg==