Re: [PATCH rdma-rc] RDMA/irdma: Do not move a fresh RoCE QP to ERROR on RESET

[sashiko-bot@kernel.org]

> From: Nguyễn Văn Cao Nguyên <nguyennvc@greennode.ai>
> 
> irdma_modify_qp_roce() handles IB_QPS_RESET like IB_QPS_ERR and moves
> the QP to ERROR. On a QP that was never moved to INIT, this makes the
> following RESET->INIT fail with -EINVAL, while ibv_query_qp() still
> reports RESET.
> 
> RESET->RESET is a valid transition. The Mooncake transfer engine
> resets every new QP before INIT, so it cannot connect over an E810,
> while mlx5 accepts the same sequence:
> 
>   ibv_create_qp(RC)        -> RESET
>   ibv_modify_qp(RESET)     -> 0
>   ibv_modify_qp(INIT, ...) -> -EINVAL
> 
> Skip the hardware modify when the QP has not been moved to INIT yet
> (iwarp_state is IRDMA_QP_STATE_INVALID), as there is nothing to flush.
> RESET after INIT still goes to ERROR.
> 
> Fixes: b48c24c2d710 ("RDMA/irdma: Implement device supported verb APIs")
> Assisted-by: LLM
> Signed-off-by: Nguyễn Văn Cao Nguyên <nguyennvc@greennode.ai>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260930-irdma-reset-fresh-qp-v1-1-065327274e2b@greennode.ai?part=1