Re: [PATCH 2/4] arm64: dts: rockchip: add Forlinx FET3568-C

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt: missing dt-bindings/leds/common.h include in rk3568-fet3568-c.dtsi
--

commit ad3d32e56e87934cf5904354535bfdac90366416
Author: Dmitry Yashin <dmt.yashin@gmail.com>

arm64: dts: rockchip: add Forlinx FET3568-C

This commit adds the device tree source for the Forlinx FET3568-C System on
Module based on the Rockchip RK3568 SoC. It configures the CPU, GPU, I2C,
PMIC, eMMC, and basic LED nodes for the SoM.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-fet3568-c.dtsi b/arch/arm64/boot/dts/rockchip/rk3568-fet3568-c.dtsi
> new file mode 100644
> index 0000000000000..258e7591063fb
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-fet3568-c.dtsi
> @@ -0,0 +1,331 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include "rk3568.dtsi"
> +
> +/ {
> +	compatible = "forlinx,fet3568-c", "rockchip,rk3568";

[ ... ]

> +	leds {
> +		compatible = "gpio-leds";
> +
> +		led-0 {
> +			color = <LED_COLOR_ID_BLUE>;
> +			default-state = "on";
> +			function = LED_FUNCTION_HEARTBEAT;

[Severity: Low]
This file uses LED_COLOR_ID_BLUE and LED_FUNCTION_HEARTBEAT but doesn't
include <dt-bindings/leds/common.h>. Could we include the header directly
in this .dtsi file so it is fully self-contained? Relying on parent .dts
files to include it can cause build failures if this file is included by
other boards.

> +			gpios = <&gpio0 RK_PB7 GPIO_ACTIVE_HIGH>;
> +			linux,default-trigger = "heartbeat";
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&led0_pin>;
> +		};
> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260930-ok3568-c-v1-0-a0ffd55f5c95@gmail.com?part=2