Re: [PATCH v3 05/10] rust: pci: add num_vf(), to return number of VFs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] rust: pci: missing #[inline] on num_vf() abstraction
--

commit c909cec9ddd3766a8c4ba947c0d935d2555ad9f2
Author: Peter Colberg <peter@colberg.org>

rust: pci: add num_vf(), to return number of VFs

This commit adds a num_vf method to the Device abstraction to query the
number of Virtual Functions enabled for a Physical Function.

> diff --git a/rust/kernel/pci/iov.rs b/rust/kernel/pci/iov.rs
> index a4a23a9ea77ae..4f611d5d0b89f 100644
> --- a/rust/kernel/pci/iov.rs
> +++ b/rust/kernel/pci/iov.rs
> @@ -28,6 +28,14 @@ pub fn is_virtfn(&self) -> bool {
>      }
>  }
>  
> +impl Device<device::Core<'_>> {
> +    /// Returns the number of Virtual Functions (VF) enabled for a Physical Function (PF).
> +    pub fn num_vf(&self) -> i32 {

[Severity: Low]
Does num_vf() need an #[inline] attribute? Small functions in abstraction 
crates that merely forward to a C binding usually require the #[inline] 
attribute to ensure optimal code generation, according to the Rust subsystem 
coding guidelines.

> +        // SAFETY: `self.as_raw()` is valid and this call runs in the PCI core callback context.
> +        unsafe { bindings::pci_num_vf(self.as_raw()) }
> +    }
> +}

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1790705494.git.zhiw@nvidia.com?part=5